Changeset 22409

Timestamp:

11/06/2012 11:23:03 PM (12 years ago)

Author:

nacin

Message:

Stop adding title attributes to images (in the old media uploader). props martythornley. fixes #18984.

Location:

trunk

Files:

• wp-admin/includes/media.php (modified) (2 diffs)
• wp-includes/media.php (modified) (2 diffs)

trunk/wp-admin/includes/media.php

@@ -1528 +1528 @@
             return false;
 
-        if ( f.title.value ) {
-            title = f.title.value.replace(/'/g, '&#039;').replace(/"/g, '&quot;').replace(/</g, '&lt;').replace(/>/g, '&gt;');
-            title = ' title="'+title+'"';
-        }
-
         if ( f.alt.value )
             alt = f.alt.value.replace(/'/g, '&#039;').replace(/"/g, '&quot;').replace(/</g, '&lt;').replace(/>/g, '&gt;');
@@ -1549 +1544 @@
         cls = caption ? '' : ' class="'+t.align+'"';
 
-        html = '<img alt="'+alt+'" src="'+f.src.value+'"'+title+cls+' width="'+t.width+'" height="'+t.height+'" />';
+        html = '<img alt="'+alt+'" src="'+f.src.value+'"'+cls+' width="'+t.width+'" height="'+t.height+'" />';
 
         if ( f.url.value ) {

trunk/wp-includes/media.php

@@ -229 +229 @@
     $class = apply_filters('get_image_tag_class', $class, $id, $align, $size);
 
-    $html = '<img src="' . esc_attr($img_src) . '" alt="' . esc_attr($alt) . '" title="' . esc_attr($title).'" '.$hwstring.'class="'.$class.'" />';
+    $html = '<img src="' . esc_attr($img_src) . '" alt="' . esc_attr($alt) . '" '.$hwstring.'class="'.$class.'" />';
 
     $html = apply_filters( 'get_image_tag', $html, $id, $alt, $title, $align, $size );
@@ -549 +549 @@
             'class' => "attachment-$size",
             'alt'   => trim(strip_tags( get_post_meta($attachment_id, '_wp_attachment_image_alt', true) )), // Use Alt field first
-            'title' => trim(strip_tags( $attachment->post_title )),
         );
         if ( empty($default_attr['alt']) )