Changeset 22603

Timestamp:

11/15/2012 11:53:06 PM (12 years ago)

Author:

koopersmith

Message:

Media: Update in-grid captions.

• Use input fields instead of textboxes (which provide better handling for smaller attachments).
• Provide data-setting properties to properly sync the changes.

see #21390.

Location:

trunk/wp-includes

Files:

• css/media-views.css (modified) (1 diff)
• media.php (modified) (2 diffs)

trunk/wp-includes/css/media-views.css

@@ -604 +604 @@
     display: block;
     width: 100%;
-    height: 50px;
     margin: -1px 0 0;
     padding: 8px;

trunk/wp-includes/media.php

@@ -1448 +1448 @@
         <# if ( data.describe ) { #>
             <# if ( 'image' === data.type ) { #>
-                <textarea class="describe"
-                    placeholder="<?php esc_attr_e('Describe this image&hellip;'); ?>"
-                    >{{ data.caption }}</textarea>
+                <input type="text" value="{{ data.caption }}" class="describe" data-setting="caption"
+                    placeholder="<?php esc_attr_e('Describe this image&hellip;'); ?>" />
             <# } else { #>
-                <textarea class="describe"
+                <input type="text" value="{{ data.title }}" class="describe" data-setting="title"
                     <# if ( 'video' === data.type ) { #>
                         placeholder="<?php esc_attr_e('Describe this video&hellip;'); ?>"
@@ -1459 +1458 @@
                     <# } else { #>
                         placeholder="<?php esc_attr_e('Describe this media file&hellip;'); ?>"
-                    <# } #>
-                    >{{ data.title }}</textarea>
+                    <# } #> />
             <# } #>
         <# } #>