Changeset 22654

Timestamp:

11/19/2012 02:00:01 AM (12 years ago)

Author:

koopersmith

Message:

Media: Remove redundant sorting logic from composite models. see #21390.

File:

• trunk/wp-includes/js/media-models.js (modified) (2 diffs)

trunk/wp-includes/js/media-models.js

@@ -748 +748 @@
                 hasAttachment = !! this.getByCid( attachment.cid );
 
-            if ( ! valid && hasAttachment ) {
+            if ( ! valid && hasAttachment )
                 this.remove( attachment, options );
-            } else if ( valid && ! hasAttachment ) {
+            else if ( valid && ! hasAttachment )
                 this.add( attachment, options );
-
-                // If we haven't been silenced, resort the collection.
-                if ( this.comparator && ( ! options || ! options.silent ) )
-                    this.sort({ silent: true });
-            }
 
             return this;
@@ -770 +765 @@
             }, this );
 
-            if ( this.comparator )
-                this.sort( options );
             return this;
         },