Changeset 22687

Timestamp:

11/19/2012 07:23:54 PM (12 years ago)

Author:

nacin

Message:

As wp_dropdown_roles() only prints editable roles, ensure that the
"selected" role passed into it on the user-edit screen is editable.

props johnjamesjacoby. see #22361.

File:

• trunk/wp-admin/user-edit.php (modified) (1 diff)

trunk/wp-admin/user-edit.php

@@ -250 +250 @@
 <td><select name="role" id="role">
 <?php
-// Get the highest/primary role for this user
+// Compare user role against currently editable roles
 // TODO: create a function that does this: wp_get_user_role()
-$user_roles = $profileuser->roles;
-$user_role = array_shift($user_roles);
+$user_roles = array_intersect( array_values( $profileuser->roles ), array_keys( get_editable_roles() ) );
+$user_role  = array_shift( $user_roles );
 
 // print the full list of roles with the primary one selected.