Changeset 22699

Timestamp:

11/20/2012 02:35:30 AM (12 years ago)

Author:

koopersmith

Message:

Media: Improve media buttons on the front end.

• Use a less specific selector (the body, actually) to delegate opening the media dialog.
• Allow the editor ID to be the empty string so the media_buttons action can be called without arguments.

see #22284, #21390.

Location:

trunk/wp-admin

Files:

• includes/media.php (modified) (1 diff)
• js/media-upload.js (modified) (2 diffs)

trunk/wp-admin/includes/media.php

@@ -391 +391 @@
 
     $img = '<span class="wp-media-buttons-icon"></span> ';
+
+    error_log( 'MEDIA_BUTTONS ' . print_r( func_get_args(), true ) );
 
     echo '<a href="#" class="button insert-media add_media" data-editor="' . esc_attr( $editor_id ) . '" title="' . esc_attr__( 'Add Media' ) . '">' . $img . __( 'Add Media' ) . '</a>';

trunk/wp-admin/js/media-upload.js

@@ -435 +435 @@
 
         init: function() {
-            $('#wpbody').on('click', '.insert-media', function( event ) {
+            $(document.body).on('click', '.insert-media', function( event ) {
                 var $this = $(this),
                     editor = $this.data('editor'),
@@ -449 +449 @@
                 $this.blur();
 
-                if ( ! editor )
+                if ( ! _.isString( editor ) )
                     return;