Changeset 22731

Timestamp:

11/20/2012 09:25:54 PM (12 years ago)

Author:

nacin

Message:

Customizer: Let return/enter fire click events for dropdowns and links. Remove errant focus event. Re-add box shadow and border for the overlay header. props lessbloat. see #21283.

Location:

trunk/wp-admin

Files:

• css/wp-admin.css (modified) (1 diff)
• js/customize-controls.js (modified) (5 diffs)

trunk/wp-admin/css/wp-admin.css

@@ -5534 +5534 @@
 }
 
+.wp-full-overlay-sidebar .wp-full-overlay-header { 
+    border-top: 0;  
+    border-bottom: 1px solid #fff;  
+    box-shadow: inset 0 -1px 0 0px #dfdfdf;  
+}
+
 .wp-full-overlay-sidebar .wp-full-overlay-footer {
     bottom: 0;

trunk/wp-admin/js/customize-controls.js

@@ -99 +99 @@
 
             // Support the .dropdown class to open/close complex elements
-            this.container.on( 'click focus', '.dropdown', function( event ) {
+            this.container.on( 'click keydown', '.dropdown', function( event ) {
+                if ( event.type === 'keydown' &&  13 !== event.which ) // enter
+                    return;
+
                 event.preventDefault();
 
@@ -169 +172 @@
 
             this.remover = this.container.find('.remove');
-            this.remover.click( function( event ) {
+            this.remover.on( 'click keydown', function( event ) {
+                if ( event.type === 'keydown' &&  13 !== event.which ) // enter
+                    return;
+
                 control.setting.set( control.params.removed );
                 event.preventDefault();
@@ -233 +239 @@
             // Bind tab switch events
             this.library.children('ul').on( 'click keydown', 'li', function( event ) {
-
-                if ( event.type === 'keydown' &&  13 !== event.which )
+                if ( event.type === 'keydown' &&  13 !== event.which ) // enter
                     return;
 
@@ -252 +257 @@
             // Bind events to switch image urls.
             this.library.on( 'click keydown', 'a', function( event ) {
-                if ( event.type === 'keydown' &&  13 !== event.which ) // enter
+                if ( event.type === 'keydown' && 13 !== event.which ) // enter
                     return;
 
@@ -883 +888 @@
         });
 
-        $('.collapse-sidebar').click( function( event ) {
+        $('.collapse-sidebar').on( 'click keydown', function( event ) {
+            if ( event.type === 'keydown' &&  13 !== event.which ) // enter
+                return;
+
             overlay.toggleClass( 'collapsed' ).toggleClass( 'expanded' );
             event.preventDefault();