Changeset 22817 for trunk/wp-admin/includes/image-edit.php

Timestamp:

11/22/2012 09:52:16 AM (12 years ago)

Author:

nacin

Message:

WP_Image_Editor: the last stand.

• Have wp_get_image_editor() rather than WP_Image_Editor::get_instance(). Having static factory methods would be less confusing if there weren't also static methods tied to individual editor implementations.
• Lazy-load the WP_Image_Editor base class and editor implementations.
• Have WP_Image_Editor_GD::supports_mime_type() actually check which types it supports.
• Deprecate gd_edit_image_support() in favor of wp_image_editor_supports().

props DH-Shredder, scribu, markoheijnen. fixes #22356. see #6821.

File:

• trunk/wp-admin/includes/image-edit.php (modified) (2 diffs)

trunk/wp-admin/includes/image-edit.php

@@ -458 +458 @@
     @ini_set( 'memory_limit', apply_filters( 'admin_memory_limit', WP_MAX_MEMORY_LIMIT ) );
 
-    $img = WP_Image_Editor::get_instance( _load_image_to_edit_path( $post_id ) );
+    $img = wp_get_image_editor( _load_image_to_edit_path( $post_id ) );
 
     if ( is_wp_error( $img ) )
@@ -567 +567 @@
     $post = get_post( $post_id );
 
-    $img = WP_Image_Editor::get_instance( _load_image_to_edit_path( $post_id, 'full' ) );
+    $img = wp_get_image_editor( _load_image_to_edit_path( $post_id, 'full' ) );
     if ( is_wp_error( $img ) ) {
         $return->error = esc_js( __('Unable to create new image.') );