Changeset 22979 for trunk/wp-admin/includes/ajax-actions.php

Timestamp:

12/03/2012 02:38:10 AM (13 years ago)

Author:

nacin

Message:

Bring Featured Images back into the main media dialog.

Most users don't realize that the Featured Image meta box exists; if they do, few use it.

Restores the old meta box UI, including the admin_post_thumbnail_html filter. If a plugin is using _wp_post_thumbnail_html() in conjunction with Thickbox elsewhere, it will also magically still work.

Specific underlying changes:

• Converts the modal view to use the view manager, which means that a call to open() will automatically call render and attach if necessary.
• Doesn't automatically set a state in wp.media, to allow code to customize the states to be added before activation.

props koopersmith.
fixes #21776.

File:

• trunk/wp-admin/includes/ajax-actions.php (modified) (2 diffs)

trunk/wp-admin/includes/ajax-actions.php

@@ -1675 +1675 @@
 
 function wp_ajax_set_post_thumbnail() {
+    $json = ! empty( $_REQUEST['json'] );
+
     $post_ID = intval( $_POST['post_id'] );
-    if ( !current_user_can( 'edit_post', $post_ID ) )
-        wp_die( -1 );
+    if ( !current_user_can( 'edit_post', $post_ID ) ) {
+        $json ? wp_send_json_error() : wp_die( -1 );
+    }
     $thumbnail_id = intval( $_POST['thumbnail_id'] );
 
@@ -1683 +1686 @@
 
     if ( $thumbnail_id == '-1' ) {
-        if ( delete_post_thumbnail( $post_ID ) )
-            wp_die( _wp_post_thumbnail_html( null, $post_ID ) );
-        else
-            wp_die( 0 );
-    }
-
-    if ( set_post_thumbnail( $post_ID, $thumbnail_id ) )
-        wp_die( _wp_post_thumbnail_html( $thumbnail_id, $post_ID ) );
-    wp_die( 0 );
+        if ( delete_post_thumbnail( $post_ID ) ) {
+            $return = _wp_post_thumbnail_html( null, $post_ID );
+            $json ? wp_send_json_success( $return ) : wp_die( $return );
+        } else {
+            $json ? wp_send_json_error() : wp_die( 0 );
+        }
+    }
+
+    if ( set_post_thumbnail( $post_ID, $thumbnail_id ) ) {
+        $return = _wp_post_thumbnail_html( $thumbnail_id, $post_ID );
+        $json ? wp_send_json_success( $return ) : wp_die( $return );
+    }
+
+    $json ? wp_send_json_error() : wp_die( 0 );
 }