Changeset 22993

Timestamp:

12/03/2012 07:04:34 AM (13 years ago)

Author:

ryan

Message:

When settting a featured image, move the currently selected image to the beginning of the library if it doesn't exist within the attachments loaded so far.

Props koopersmith
fixes #22494

File:

• trunk/wp-includes/js/media-views.js (modified) (2 diffs)

trunk/wp-includes/js/media-views.js

@@ -576 +576 @@
 
         initialize: function() {
+            var library, comparator;
+
             // If we haven't been provided a `library`, create a `Selection`.
             if ( ! this.get('library') )
@@ -581 +583 @@
 
             media.controller.Library.prototype.initialize.apply( this, arguments );
+
+            library    = this.get('library');
+            comparator = library.comparator;
+
+            // Overload the library's comparator to push items that are not in
+            // the mirrored query to the front of the aggregate collection.
+            library.comparator = function( a, b ) {
+                var aInQuery = !! this.mirroring.getByCid( a.cid ),
+                    bInQuery = !! this.mirroring.getByCid( b.cid );
+
+                if ( ! aInQuery && bInQuery )
+                    return -1;
+                else if ( aInQuery && ! bInQuery )
+                    return 1;
+                else
+                    return comparator.apply( this, arguments );
+            };
+
+            // Add all items in the selection to the library, so any featured
+            // images that are not initially loaded still appear.
+            library.observe( this.get('selection') );
         },