Changeset 23083 for trunk/wp-includes/media.php

Timestamp:

12/06/2012 12:41:06 AM (12 years ago)

Author:

nacin

Message:

Restore the Description field to the media UI in 3.5.

We tried in vain -- a noble but ultimately failed effort -- to reduce the number of fields for attachments from four (title, caption, alt, description) to one (caption for images, title otherwise). Alternative text needed to stay for accessibility reasons, of course.

Eventually title returned due to heavy plugin reliance. Description is too used by too many plugins (often times incorrectly -- the caption is more likely the proper field), hence its less-than-triumphant return today.

Version 3.5 has tried to streamline media in a number of ways. Removing fields may have been too much at once, as it forced not only a user interface change, but a paradigm change as well.

Finally, on upload we populate the description field with IPTC/EXIF captions, rather than the caption field. See #22768, this should be fixed. For now, Description stays.

This commit also restores 'Title' attribute editing to the main tab of the Edit Image dialog. The "Title" field no longer populates title attributes for <img> tags by design (for accessibility and other purposes, see #18984). So, here is a more obvious 'workaround' for the tooltip community.

Finally, this:

• Cleans up the post.php attachment editor, including by showing a prettier form of the mime type.
• Enables plugins to specifically hide attachment_fields_to_edit from either post.php (where you can create meta boxes) or the modal (which you may not want to clutter), for compatibility reasons.
• Hides the 'Describe this file...' placeholder when a field is read-only in the modal.

props nacin, helenyhou.
fixes #22759.

File:

• trunk/wp-includes/media.php (modified) (2 diffs)

trunk/wp-includes/media.php

@@ -1396 +1396 @@
 
     if ( function_exists('get_compat_media_markup') )
-        $response['compat'] = get_compat_media_markup( $attachment->ID, array( 'taxonomies' => true, 'description' => true ) );
+        $response['compat'] = get_compat_media_markup( $attachment->ID, array( 'in_modal' => true ) );
 
     return apply_filters( 'wp_prepare_attachment_for_js', $response, $attachment, $meta );
@@ -1741 +1741 @@
                 <span><?php _e('Title'); ?></span>
                 <input type="text" value="{{ data.title }}" {{ maybeReadOnly }}
-                <# if ( 'video' === data.type ) { #>
-                    placeholder="<?php esc_attr_e('Describe this video&hellip;'); ?>"
-                <# } else if ( 'audio' === data.type ) { #>
-                    placeholder="<?php esc_attr_e('Describe this audio file&hellip;'); ?>"
-                <# } else { #>
-                    placeholder="<?php esc_attr_e('Describe this media file&hellip;'); ?>"
-                <# } #>/>
+                <# if ( ! maybeReadOnly ) { #>
+                    <# if ( 'video' === data.type ) { #>
+                        placeholder="<?php esc_attr_e('Describe this video&hellip;'); ?>"
+                    <# } else if ( 'audio' === data.type ) { #>
+                        placeholder="<?php esc_attr_e('Describe this audio file&hellip;'); ?>"
+                    <# } else { #>
+                        placeholder="<?php esc_attr_e('Describe this media file&hellip;'); ?>"
+                    <# } #>
+                <# } #>
+                />
             </label>
         <# } #>
+            <label class="setting" data-setting="description">
+                <span><?php _e('Description'); ?></span>
+                <textarea {{ maybeReadOnly }}>{{ data.description }}</textarea>
+            </label>
     </script>