Changeset 23085

Timestamp:

12/06/2012 03:15:39 AM (12 years ago)

Author:

koopersmith

Message:

Do not alter the body's overflow attribute when the media modal is opened. Fix image insertion in the visual editor in Firefox. props azaozz. fixes #22765.

File:

• trunk/wp-includes/js/media-views.js (modified) (4 diffs)

trunk/wp-includes/js/media-views.js

@@ -1850 +1850 @@
                 title:     '',
                 propagate: true,
-                freeze:    document.body
+                freeze:    true
             });
         },
@@ -1887 +1887 @@
         open: function() {
             var $el = this.$el,
-                options = this.options,
-                $freeze;
+                options = this.options;
 
             if ( $el.is(':visible') )
@@ -1896 +1895 @@
                 this.attach();
 
-            // If the `freeze` option is set, record the window's scroll
-            // position and the body's overflow, and then set overflow to hidden.
+            // If the `freeze` option is set, record the window's scroll position.
             if ( options.freeze ) {
-                $freeze = $( options.freeze );
                 this._freeze = {
-                    overflow:  $freeze.css('overflow'),
                     scrollTop: $( window ).scrollTop()
                 };
-                $freeze.css( 'overflow', 'hidden' );
             }
 
@@ -1920 +1915 @@
             this.propagate('close');
 
-            // If the `freeze` option is set, restore the container's scroll
-            // position and overflow property.
+            // If the `freeze` option is set, restore the container's scroll position.
             if ( freeze ) {
-                $( this.options.freeze ).css( 'overflow', freeze.overflow );
                 $( window ).scrollTop( freeze.scrollTop );
             }