Changeset 23300

Timestamp:

01/15/2013 05:32:35 PM (12 years ago)

Author:

ryan

Message:

In get_pages(), cache queries to individual cache buckets instead of storing them in one cached array. Also, store post IDs instead of full objects. This reduces overall memory usage as well as the size of the cache buckets. Use incrementor style passive cache invalidation.

Props nprasath002
see #23167

File:

• trunk/wp-includes/post.php (modified) (3 diffs)

trunk/wp-includes/post.php

@@ -3650 +3650 @@
         return $pages;
 
-    $cache = array();
+    // $args can be whatever, only use the args defined in defaults to compute the key
     $key = md5( serialize( compact(array_keys($defaults)) ) );
-    if ( $cache = wp_cache_get( 'get_pages', 'posts' ) ) {
-        if ( is_array($cache) && isset( $cache[ $key ] ) && is_array( $cache[ $key ] ) ) {
-            // Convert to WP_Post instances
-            $pages = array_map( 'get_post', $cache[ $key ] );
-            $pages = apply_filters( 'get_pages', $pages, $r );
-            return $pages;
-        }
+    $last_changed = wp_cache_get( 'last_changed', 'posts' );
+    if ( ! $last_changed )
+        $last_changed = wp_cache_set( 'last_changed', 1, 'posts' );
+
+    $cache_key = "get_pages:$key:$last_changed";
+    if ( $cache = wp_cache_get( $cache_key, 'posts' ) ) {
+        // Convert to WP_Post instances
+        $pages = array_map( 'get_post', $cache );
+        $pages = apply_filters('get_pages', $pages, $r);
+        return $pages;
     }
 
@@ -3828 +3831 @@
     }
 
-    $cache[ $key ] = $pages;
-    wp_cache_set( 'get_pages', $cache, 'posts' );
+    $page_structure = array();
+    foreach ( $pages as $page )
+        $page_structure[] = $page->ID;
+
+    wp_cache_set( $cache_key, $page_structure, 'posts' );
 
     // Convert to WP_Post instances
@@ -4664 +4670 @@
         do_action( 'clean_page_cache', $post->ID );
     }
+
+    if ( function_exists( 'wp_cache_incr' ) ) {
+        wp_cache_incr( 'last_changed', 1, 'posts' );
+    } else {
+        $last_changed = wp_cache_get( 'last_changed', 'posts' );
+        wp_cache_set( 'last_changed', $last_changed + 1, 'posts' );
+    }
 }