Changeset 23414

Timestamp:

02/14/2013 11:36:32 AM (12 years ago)

Author:

westi

Message:

Revisions: Before saving a new post revision make sure that something has changed in the fields that we are revisioning.

Fixes: #7392 and #9843 props adamsilverstein.

Location:

trunk/wp-includes

Files:

• default-filters.php (modified) (1 diff)
• post.php (modified) (3 diffs)

trunk/wp-includes/default-filters.php

@@ -250 +250 @@
 add_action( 'plugins_loaded',             'wp_maybe_load_embeds',                     0    );
 add_action( 'shutdown',                   'wp_ob_end_flush_all',                      1    );
-add_action( 'pre_post_update',            'wp_save_post_revision'                          );
+add_action( 'pre_post_update',            'wp_save_post_revision',                   10, 2 );
 add_action( 'publish_post',               '_publish_post_hook',                       5, 1 );
 add_action( 'transition_post_status',     '_transition_post_status',                  5, 3 );

trunk/wp-includes/post.php

@@ -2867 +2867 @@
 
     if ( $update ) {
-        do_action( 'pre_post_update', $post_ID );
+        do_action( 'pre_post_update', $post_ID, $data );
         if ( false === $wpdb->update( $wpdb->posts, $data, $where ) ) {
             if ( $wp_error )
@@ -4930 +4930 @@
  * @return mixed Null or 0 if error, new revision ID, if success.
  */
-function wp_save_post_revision( $post_id ) {
+function wp_save_post_revision( $post_id, $new_data = null ) {
     // We do autosaves manually with wp_create_post_autosave()
     if ( defined( 'DOING_AUTOSAVE' ) && DOING_AUTOSAVE )
@@ -4947 +4947 @@
     if ( !post_type_supports($post['post_type'], 'revisions') )
         return;
+
+    // if new data is supplied, check that it is different from last saved revision
+    if( is_array( $new_data ) ) {
+        $post_has_changed = false;
+        foreach( array_keys( _wp_post_revision_fields() ) as $field ) {
+            if( normalize_whitespace( $new_data[ $field ] ) != normalize_whitespace( $post[ $field ] ) ) {
+                $post_has_changed = true;
+                break;
+            }
+        }
+        //don't save revision if post unchanged
+        if( ! $post_has_changed )
+            return;
+    }
 
     $return = _wp_put_post_revision( $post );