Changeset 23416 for trunk/wp-admin/includes/user.php

Timestamp:

02/14/2013 10:51:06 PM (7 years ago)

Author:

ryan

Message:

Change all core API to expect unslashed rather than slashed arguments.

The exceptions to this are update_post_meta() and add_post_meta() which are often used by plugins in POST handlers and will continue accepting slashed data for now.

Introduce wp_upate_post_meta() and wp_add_post_meta() as unslashed alternatives to update_post_meta() and add_post_meta(). These functions could become methods in WP_Post so don't use them too heavily yet.

Remove all escape() calls from wp_xmlrpc_server. Now that core expects unslashed data this is no longer needed.

Remove addslashes(), addslashes_gpc(), add_magic_quotes() calls on data being prepared for handoff to core functions that until now expected slashed data. Adding slashes in no longer necessary.

Introduce wp_unslash() and use to it remove slashes from GPCS data before using it in core API. Almost every instance of stripslashes() in core should now be wp_unslash(). In the future (a release or three) when GPCS is no longer slashed, wp_unslash() will stop stripping slashes and simply return what is passed. At this point wp_unslash() calls can be removed from core.

Introduce wp_slash() for slashing GPCS data. This will also turn into a noop once GPCS is no longer slashed. wp_slash() should almost never be used. It is mainly of use in unit tests.

Plugins should use wp_unslash() on data being passed to core API.

Plugins should no longer slash data being passed to core. So when you get_post() and then wp_insert_post() the post data from get_post() no longer needs addslashes(). Most plugins were not bothering with this. They will magically start doing the right thing. Unfortunately, those few souls who did it properly will now have to avoid calling addslashes() for 3.6 and newer.

Use wp_kses_post() and wp_kses_data(), which expect unslashed data, instead of wp_filter_post_kses() and wp_filter_kses(), which expect slashed data. Filters are no longer passed slashed data.

Remove many no longer necessary calls to $wpdb->escape() and esc_sql().

In wp_get_referer() and wp_get_original_referer(), return unslashed data.

Remove old stripslashes() calls from WP_Widget::update() handlers. These haven't been necessary since WP_Widget.

Switch several queries over to prepare().

Expect something to break.

Props alexkingorg
see #21767

File:

• trunk/wp-admin/includes/user.php (modified) (5 diffs)

trunk/wp-admin/includes/user.php

@@ -35 +35 @@
         $user->ID = (int) $user_id;
         $userdata = get_userdata( $user_id );
-        $user->user_login = $wpdb->escape( $userdata->user_login );
+        $user->user_login = $userdata->user_login;
     } else {
         $update = false;
     }
 
-    if ( !$update && isset( $_POST['user_login'] ) )
-        $user->user_login = sanitize_user($_POST['user_login'], true);
+    // get clean data before we get started.
+    $post_data = wp_unslash( $_POST );
+
+    if ( !$update && isset( $post_data['user_login'] ) )
+        $user->user_login = sanitize_user($post_data['user_login'], true);
 
     $pass1 = $pass2 = '';
-    if ( isset( $_POST['pass1'] ))
-        $pass1 = $_POST['pass1'];
-    if ( isset( $_POST['pass2'] ))
-        $pass2 = $_POST['pass2'];
-
-    if ( isset( $_POST['role'] ) && current_user_can( 'edit_users' ) ) {
-        $new_role = sanitize_text_field( $_POST['role'] );
+    if ( isset( $post_data['pass1'] ))
+        $pass1 = $post_data['pass1'];
+    if ( isset( $post_data['pass2'] ))
+        $pass2 = $post_data['pass2'];
+
+    if ( isset( $post_data['role'] ) && current_user_can( 'edit_users' ) ) {
+        $new_role = sanitize_text_field( $post_data['role'] );
         $potential_role = isset($wp_roles->role_objects[$new_role]) ? $wp_roles->role_objects[$new_role] : false;
         // Don't let anyone with 'edit_users' (admins) edit their own role to something without it.
@@ -63 +66 @@
     }
 
-    if ( isset( $_POST['email'] ))
-        $user->user_email = sanitize_text_field( $_POST['email'] );
-    if ( isset( $_POST['url'] ) ) {
-        if ( empty ( $_POST['url'] ) || $_POST['url'] == 'http://' ) {
+    if ( isset( $post_data['email'] ))
+        $user->user_email = sanitize_text_field( $post_data['email'] );
+    if ( isset( $post_data['url'] ) ) {
+        if ( empty ( $post_data['url'] ) || $post_data['url'] == 'http://' ) {
             $user->user_url = '';
         } else {
-            $user->user_url = esc_url_raw( $_POST['url'] );
+            $user->user_url = esc_url_raw( $post_data['url'] );
             $protocols = implode( '|', array_map( 'preg_quote', wp_allowed_protocols() ) );
             $user->user_url = preg_match('/^(' . $protocols . '):/is', $user->user_url) ? $user->user_url : 'http://'.$user->user_url;
         }
     }
-    if ( isset( $_POST['first_name'] ) )
-        $user->first_name = sanitize_text_field( $_POST['first_name'] );
-    if ( isset( $_POST['last_name'] ) )
-        $user->last_name = sanitize_text_field( $_POST['last_name'] );
-    if ( isset( $_POST['nickname'] ) )
-        $user->nickname = sanitize_text_field( $_POST['nickname'] );
-    if ( isset( $_POST['display_name'] ) )
-        $user->display_name = sanitize_text_field( $_POST['display_name'] );
-
-    if ( isset( $_POST['description'] ) )
-        $user->description = trim( $_POST['description'] );
+    if ( isset( $post_data['first_name'] ) )
+        $user->first_name = sanitize_text_field( $post_data['first_name'] );
+    if ( isset( $post_data['last_name'] ) )
+        $user->last_name = sanitize_text_field( $post_data['last_name'] );
+    if ( isset( $post_data['nickname'] ) )
+        $user->nickname = sanitize_text_field( $post_data['nickname'] );
+    if ( isset( $post_data['display_name'] ) )
+        $user->display_name = sanitize_text_field( $post_data['display_name'] );
+
+    if ( isset( $post_data['description'] ) )
+        $user->description = trim( $post_data['description'] );
 
     foreach ( _wp_get_user_contactmethods( $user ) as $method => $name ) {
-        if ( isset( $_POST[$method] ))
-            $user->$method = sanitize_text_field( $_POST[$method] );
+        if ( isset( $post_data[$method] ))
+            $user->$method = sanitize_text_field( $post_data[$method] );
     }
 
     if ( $update ) {
-        $user->rich_editing = isset( $_POST['rich_editing'] ) && 'false' == $_POST['rich_editing'] ? 'false' : 'true';
-        $user->admin_color = isset( $_POST['admin_color'] ) ? sanitize_text_field( $_POST['admin_color'] ) : 'fresh';
-        $user->show_admin_bar_front = isset( $_POST['admin_bar_front'] ) ? 'true' : 'false';
-    }
-
-    $user->comment_shortcuts = isset( $_POST['comment_shortcuts'] ) && 'true' == $_POST['comment_shortcuts'] ? 'true' : '';
+        $user->rich_editing = isset( $post_data['rich_editing'] ) && 'false' == $post_data['rich_editing'] ? 'false' : 'true';
+        $user->admin_color = isset( $post_data['admin_color'] ) ? sanitize_text_field( $post_data['admin_color'] ) : 'fresh';
+        $user->show_admin_bar_front = isset( $post_data['admin_bar_front'] ) ? 'true' : 'false';
+    }
+
+    $user->comment_shortcuts = isset( $post_data['comment_shortcuts'] ) && 'true' == $post_data['comment_shortcuts'] ? 'true' : '';
 
     $user->use_ssl = 0;
-    if ( !empty($_POST['use_ssl']) )
+    if ( !empty($post_data['use_ssl']) )
         $user->use_ssl = 1;
 
@@ -125 +128 @@
 
     /* Check for "\" in password */
-    if ( false !== strpos( stripslashes($pass1), "\\" ) )
+    if ( false !== strpos( $pass1, "\\" ) )
         $errors->add( 'pass', __( '<strong>ERROR</strong>: Passwords may not contain the character "\\".' ), array( 'form-field' => 'pass1' ) );
 
@@ -135 +138 @@
         $user->user_pass = $pass1;
 
-    if ( !$update && isset( $_POST['user_login'] ) && !validate_username( $_POST['user_login'] ) )
+    if ( !$update && isset( $post_data['user_login'] ) && !validate_username( $post_data['user_login'] ) )
         $errors->add( 'user_login', __( '<strong>ERROR</strong>: This username is invalid because it uses illegal characters. Please enter a valid username.' ));
 
@@ -160 +163 @@
     } else {
         $user_id = wp_insert_user( $user );
-        wp_new_user_notification( $user_id, isset($_POST['send_password']) ? $pass1 : '' );
+        wp_new_user_notification( $user_id, isset($post_data['send_password']) ? $pass1 : '' );
     }
     return $user_id;