Changeset 23492

Timestamp:

02/26/2013 04:50:09 AM (13 years ago)

Author:

lancewillett

Message:

Twenty Thirteen: header area with no site title or tagline should still be clickable to home. Fixes #23549.

Fix also removes several !important flags that aren't necessary, relating to header text color.

Location:

trunk/wp-content/themes/twentythirteen

Files:

• header.php (modified) (1 diff)
• inc/custom-header.php (modified) (1 diff)
• js/theme-customizer.js (modified) (1 diff)
• style.css (modified) (2 diffs)

trunk/wp-content/themes/twentythirteen/header.php

@@ -40 +40 @@
     <div id="page" class="hfeed site">
         <header id="masthead" class="site-header" role="banner">
-            <hgroup>
-                <h1 class="site-title"><a href="<?php echo esc_url( home_url( '/' ) ); ?>" title="<?php echo esc_attr( get_bloginfo( 'name', 'display' ) ); ?>" rel="home"><?php bloginfo( 'name' ); ?></a></h1>
-                <h2 class="site-description"><?php bloginfo( 'description' ); ?></h2>
-            </hgroup>
+            <a href="<?php echo esc_url( home_url( '/' ) ); ?>" title="<?php echo esc_attr( get_bloginfo( 'name', 'display' ) ); ?>" rel="home">
+                <hgroup>
+                    <h1 class="site-title"><?php bloginfo( 'name' ); ?></h1>
+                    <h2 class="site-description"><?php bloginfo( 'description' ); ?></h2>
+                </hgroup>
+            </a>
 
             <div id="navbar" class="navbar">

trunk/wp-content/themes/twentythirteen/inc/custom-header.php

@@ -113 +113 @@
         elseif ( $text_color != get_theme_support( 'custom-header', 'default-text-color' ) ) :
     ?>
-        .site-title a,
+        .site-title,
         .site-description {
-            color: #<?php echo esc_attr( $text_color ); ?> !important;
+            color: #<?php echo esc_attr( $text_color ); ?>;
         }
     <?php endif; ?>

trunk/wp-content/themes/twentythirteen/js/theme-customizer.js

@@ -10 +10 @@
     wp.customize( 'blogname', function( value ) {
         value.bind( function( to ) {
-            $( '.site-title a' ).text( to );
+            $( '.site-title' ).text( to );
         } );
     } );

trunk/wp-content/themes/twentythirteen/style.css

@@ -829 +829 @@
 .site-header a {
     color: #141412;
+    text-decoration: none;
+}
+
+.site-header .site-title:hover {
+    text-decoration: underline;
 }
 
@@ -1006 +1011 @@
 }
 
-.navbar-fixed #masthead .site-title a {
-    color: #141412 !important; /* Must override custom header text color. */
+.navbar-fixed #masthead .site-title {
+    color: #141412;
 }