Changeset 23508

Timestamp:

02/28/2013 04:10:45 PM (12 years ago)

Author:

westi

Message:

Revisions: Fix up some bugs I introduced while reviewing the mega revisions patch - when comparing two historical revisions only one half of the diff would load

See #23497 props adamsilverstein.

Location:

trunk/wp-admin

Files:

• includes/ajax-actions.php (modified) (3 diffs)
• js/revisions.js (modified) (3 diffs)

trunk/wp-admin/includes/ajax-actions.php

@@ -2141 +2141 @@
     $showautosaves = isset( $_GET['showautosaves'] ) ? $_GET['showautosaves'] : '';
     $show_split_view = isset( $_GET['show_split_view'] ) ? $_GET['show_split_view'] : '';
-    $postid = isset( $_GET['postid'] ) ? absint( $_GET['postid'] ) : '';
+    $postid = isset( $_GET['post_id'] ) ? absint( $_GET['post_id'] ) : '';
 
     $comparetwomode = ( '' == $postid ) ? false : true;
@@ -2150 +2150 @@
     //
     $alltherevisions = array();
-
     if ( '' == $postid )
         $postid = $compareto;
@@ -2159 +2158 @@
     if ( ! $revisions = wp_get_post_revisions( $postid ) )
         return;
+
 
     //if we are comparing two revisions, the first 'revision' represented by the leftmost

trunk/wp-admin/js/revisions.js

@@ -113 +113 @@
                         ajaxurl +
                         '?action=revisions-data&compareto=' + wpRevisionsSettings.post_id +
-                        '&wpRevisionsSettings.post_id=' + wpRevisionsSettings.post_id +
+                        '&post_id=' + wpRevisionsSettings.post_id +
                         '&showautosaves=' + self._autosaves +
                         '&showsplitview=' +  self._showsplitview +
@@ -121 +121 @@
                         ajaxurl +
                         '?action=revisions-data&compareto=' + self._revisions.at( self._left_diff - 1 ).get( 'ID' ) +
-                        '&wpRevisionsSettings.post_id=' + wpRevisionsSettings.post_id +
+                        '&post_id=' + wpRevisionsSettings.post_id +
                         '&showautosaves=' + self._autosaves +
                         '&showsplitview=' +  self._showsplitview +
@@ -130 +130 @@
                     ajaxurl +
                     '?action=revisions-data&compareto=' + self._revisions.at( self._right_diff - 1 ).get( 'ID' ) +
-                    '&wpRevisionsSettings.post_id=' + wpRevisionsSettings.post_id +
+                    '&post_id=' + wpRevisionsSettings.post_id +
                     '&showautosaves=' + self._autosaves +
                     '&showsplitview=' +  self._showsplitview +