Changeset 23557

Timestamp:

03/01/2013 04:40:29 PM (12 years ago)

Author:

lancewillett

Message:

Twenty Thirteen: CSS fixes to change single to double quotes, proper quoting around font-family names, and add a missing escape to a background image in custom-header.php. Props markmcwilliams, fixes #23653.

Location:

trunk/wp-content/themes/twentythirteen

Files:

• inc/custom-header.php (modified) (5 diffs)
• style.css (modified) (32 diffs)

trunk/wp-content/themes/twentythirteen/inc/custom-header.php

@@ -86 +86 @@
     ?>
         .site-header {
-            background: url("<?php header_image(); ?>") no-repeat scroll top;
+            background: url(<?php esc_url( header_image() ); ?>) no-repeat scroll top;
             background-size: 1600px auto;
         }
@@ -138 +138 @@
         <?php
         if ( ! empty( $header_image ) ) {
-            echo 'background: url("' . esc_url( $header_image ) . '") no-repeat scroll top; background-size: 1600px auto;';
+            echo 'background: url(' . esc_url( $header_image ) . ') no-repeat scroll top; background-size: 1600px auto;';
         } ?>
         padding: 0 20px;
@@ -163 +163 @@
     <?php endif; ?>
     #headimg h1 {
-        font: bold 60px/1 'Bitter', Georgia, serif;
+        font: bold 60px/1 Bitter, Georgia, serif;
         margin: 0;
         padding: 58px 0 10px;
@@ -174 +174 @@
     }
     #headimg h2 {
-        font: 200 italic 24px 'Source Sans Pro', Helvetica, sans-serif;
+        font: 200 italic 24px "Source Sans Pro", Helvetica, sans-serif;
         margin: 0;
         text-shadow: none;
@@ -194 +194 @@
 function twentythirteen_admin_header_image() {
     ?>
-    <div id="headimg" style="background: url('<?php esc_url( header_image() ); ?>') no-repeat scroll top; background-size: 1600px auto;">
+    <div id="headimg" style="background: url(<?php esc_url( header_image() ); ?>) no-repeat scroll top; background-size: 1600px auto;">
         <?php $style = ' style="color:#' . get_header_textcolor() . ';"'; ?>
         <div class="hgroup">

trunk/wp-content/themes/twentythirteen/style.css

@@ -150 +150 @@
 h6 {
     clear: both;
-    font-family: 'Bitter', Georgia, serif;
+    font-family: Bitter, Georgia, serif;
     line-height: 1.3;
 }
@@ -216 +216 @@
 samp {
     font-family: monospace, serif;
-    _font-family: 'courier new', monospace;
+    _font-family: "Courier New", monospace;
     font-size: 14px;
     -webkit-hyphens: none;
@@ -250 +250 @@
 q:before,
 q:after {
-    content: '';
+    content: "";
     content: none;
 }
@@ -459 +459 @@
 
 hr {
-    background: url("images/dotted-line.png") repeat center top;
+    background: url(images/dotted-line.png) repeat center top;
     background-size: 4px 4px;
     border: 0;
@@ -480 +480 @@
  */
 @font-face {
-    font-family: 'Genericons';
-    src: url('fonts/genericons-regular-webfont.eot');
-    src: url('fonts/genericons-regular-webfont.eot?#iefix') format('embedded-opentype'),
-         url('fonts/genericons-regular-webfont.woff') format('woff'),
-         url('fonts/genericons-regular-webfont.ttf') format('truetype'),
-         url('fonts/genericons-regular-webfont.svg#genericonsregular') format('svg');
+    font-family: Genericons;
+    src: url(fonts/genericons-regular-webfont.eot);
+    src: url(fonts/genericons-regular-webfont.eot?#iefix) format("embedded-opentype"),
+         url(fonts/genericons-regular-webfont.woff) format("woff"),
+         url(fonts/genericons-regular-webfont.ttf) format("truetype"),
+         url(fonts/genericons-regular-webfont.svg#genericonsregular) format("svg");
     font-weight: normal;
     font-style: normal;
@@ -509 +509 @@
 .error404 .page-title:before {
     -webkit-font-smoothing: antialiased;
-    font: normal 16px/1 'Genericons';
+    font: normal 16px/1 Genericons;
     vertical-align: text-bottom;
 }
@@ -945 +945 @@
 .site-header .searchform .field {
     background-color: transparent;
-    background-image: url("images/search-icon.png");
+    background-image: url(images/search-icon.png);
     background-position: 5px center;
     background-repeat: no-repeat;
@@ -1109 +1109 @@
 
 .featured-post:before {
-    content: '\f308';
+    content: "\f308";
     margin-right: 2px;
 }
 
 .entry-meta .date a:before {
-    content: '\f303';
+    content: "\f303";
 }
 
 .comments-link a:before {
-    content: '\f300';
+    content: "\f300";
     margin-right: 2px;
     top: -1px;
@@ -1125 +1125 @@
 
 .entry-meta .author a:before {
-    content: '\f304';
+    content: "\f304";
     top: -1px;
     position: relative;
@@ -1131 +1131 @@
 
 .categories-links a:first-child:before {
-    content: '\f301';
+    content: "\f301";
 }
 
 .tags-links a:first-child:before {
-    content: '\f302';
+    content: "\f302";
     top: -1px;
     position: relative;
@@ -1141 +1141 @@
 
 .edit-link a:before {
-    content: '\f411';
+    content: "\f411";
     top: -1px;
     position: relative;
@@ -1367 +1367 @@
 
 .format-aside .entry-content .date a:before {
-    content: '\f303';
+    content: "\f303";
 }
 
@@ -1385 +1385 @@
 
 .format-aside cite:before {
-    content: '\2014';
+    content: "\2014";
     margin-right: 5px;
 }
@@ -1409 +1409 @@
 .format-audio .entry-content:before {
     float: left;
-    content: '\f109';
+    content: "\f109";
     font-size: 64px;
 }
@@ -1433 +1433 @@
 
 .format-audio .audio-content {
-    background: url("images/dotted-line.png") repeat-y left top;
+    background: url(images/dotted-line.png) repeat-y left top;
     background-size: 4px 4px;
     float: right;
@@ -1464 +1464 @@
 
 .format-chat .entry-meta .date a:before {
-    content: '\f108';
+    content: "\f108";
     margin-right: 2px;
 }
@@ -1688 +1688 @@
 .format-status .entry-content:before,
 .format-status .entry-meta:before {
-    background: url("images/dotted-line.png") repeat-y left bottom;
+    background: url(images/dotted-line.png) repeat-y left bottom;
     background-size: 4px 4px;
-    content: '';
+    content: "";
     display: block;
     height: 100%;
@@ -1726 +1726 @@
 .format-status .entry-content p:first-child:before {
     background-color: rgba(0, 0, 0, 0.65);
-    content: '';
+    content: "";
     height: 3px;
     margin-top: 13px;
@@ -1748 +1748 @@
 
 .format-status .entry-meta .date a:before {
-    content: '\f105';
+    content: "\f105";
 }
 
@@ -1802 +1802 @@
 
 .attachment .entry-title:before {
-    content: '\f416';
+    content: "\f416";
     font-size: 32px;
     margin-right: 10px;
@@ -1826 +1826 @@
 
 .attachment-meta:before {
-    content: '\f307';
+    content: "\f307";
 }
 
 .full-size-link a:before {
-    content: '\f402';
+    content: "\f402";
 }
 
@@ -2139 +2139 @@
 
 .error404 .page-title:before {
-    content: '\f423';
+    content: "\f423";
     color: #e8e5ce;
     font-size: 964px;
@@ -2205 +2205 @@
 .comment-list > li:after,
 .comment-list .children > li:before {
-    background: url("images/dotted-line.png") repeat left top;
+    background: url(images/dotted-line.png) repeat left top;
     background-size: 4px 4px;
-    content: '';
+    content: "";
     display: block;
     height: 1px;
@@ -2252 +2252 @@
 
 .bypostauthor .fn:before {
-    content: '\f408';
+    content: "\f408";
 }
 
@@ -2290 +2290 @@
 
 .comment-awaiting-moderation:before {
-    content: '\f414';
+    content: "\f414";
     margin-right: 5px;
     position: relative;
@@ -2297 +2297 @@
 
 .comment-reply-link:before {
-    content: '\f412';
+    content: "\f412";
     margin-right: 3px;
 }
@@ -2331 +2331 @@
 
 #reply-title small a:before {
-    content: '\f406';
+    content: "\f406";
     vertical-align: top;
 }
@@ -2645 +2645 @@
 
     .site-header .searchform .field {
-        background-image: url("images/search-icon-2x.png");
+        background-image: url(images/search-icon-2x.png);
     }
 
@@ -2653 +2653 @@
     .comment-list > li:after,
     .comment-list .children > li:before {
-        background-image: url("images/dotted-line-2x.png");
+        background-image: url(images/dotted-line-2x.png);
     }
 }
@@ -2897 +2897 @@
 
     .menu-toggle:after {
-        content: '\f502';
+        content: "\f502";
         font-size: 12px;
         padding-left: 8px;
@@ -2905 +2905 @@
 
     .toggled-on .menu-toggle:after {
-        content: '\f500';
+        content: "\f500";
         vertical-align: -webkit-calc(2px);
         vertical-align:         calc(2px);
@@ -2988 +2988 @@
 
     .error404 .page-title:before {
-        content: '';
+        content: "";
     }