Changeset 23578 for trunk/wp-admin/includes/media.php

Timestamp:

03/01/2013 05:58:43 PM (13 years ago)

Author:

nacin

Message:

Ensure the referer functions operate completely on unslashed data: wp_referer_field(), wp_original_referer_field(), wp_get_referer(), wp_get_original_referer().

Use wp_slash() instead of addslashes().

see #21767.

File:

• trunk/wp-admin/includes/media.php (modified) (1 diff)

trunk/wp-admin/includes/media.php

@@ -468 +468 @@
 
                 if ( isset($attachment['image_alt']) ) {
-                        $image_alt = get_post_meta($attachment_id, '_wp_attachment_image_alt', true);
-                        if ( $image_alt != wp_unslash($attachment['image_alt']) ) {
-                                $image_alt = wp_strip_all_tags( wp_unslash($attachment['image_alt']), true );
+                        $image_alt = wp_unslash( $attachment['image_alt'] );
+                        if ( $image_alt != get_post_meta($attachment_id, '_wp_attachment_image_alt', true) ) {
+                                $image_alt = wp_strip_all_tags( $image_alt, true );
                                 // update_meta expects slashed
-                                update_post_meta( $attachment_id, '_wp_attachment_image_alt', addslashes($image_alt) );
+                                update_post_meta( $attachment_id, '_wp_attachment_image_alt', wp_slash( $image_alt ) );
                         }
                 }