Changeset 23578 for trunk/wp-admin/includes/post.php

Timestamp:

03/01/2013 05:58:43 PM (12 years ago)

Author:

nacin

Message:

Ensure the referer functions operate completely on unslashed data: wp_referer_field(), wp_original_referer_field(), wp_get_referer(), wp_get_original_referer().

Use wp_slash() instead of addslashes().

see #21767.

File:

• trunk/wp-admin/includes/post.php (modified) (2 diffs)

trunk/wp-admin/includes/post.php

@@ -198 +198 @@
 
     if ( isset( $post_data[ '_wp_format_url' ] ) ) {
-        update_post_meta( $post_ID, '_wp_format_url', addslashes( esc_url_raw( wp_unslash( $post_data['_wp_format_url'] ) ) ) );
+        update_post_meta( $post_ID, '_wp_format_url', wp_slash( esc_url_raw( wp_unslash( $post_data['_wp_format_url'] ) ) ) );
     }
 
@@ -236 +236 @@
     if ( 'attachment' == $post_data['post_type'] ) {
         if ( isset( $post_data[ '_wp_attachment_image_alt' ] ) ) {
-            $image_alt = get_post_meta( $post_ID, '_wp_attachment_image_alt', true );
-            if ( $image_alt != wp_unslash( $post_data['_wp_attachment_image_alt'] ) ) {
-                $image_alt = wp_strip_all_tags( wp_unslash( $post_data['_wp_attachment_image_alt'] ), true );
+            $image_alt = wp_unslash( $post_data['_wp_attachment_image_alt'] );
+            if ( $image_alt != get_post_meta( $post_ID, '_wp_attachment_image_alt', true ) ) {
+                $image_alt = wp_strip_all_tags( $image_alt, true );
                 // update_meta expects slashed
-                update_post_meta( $post_ID, '_wp_attachment_image_alt', addslashes( $image_alt ) );
+                update_post_meta( $post_ID, '_wp_attachment_image_alt', wp_slash( $image_alt ) );
             }
         }