Changeset 23615

Timestamp:

03/04/2013 11:22:17 PM (12 years ago)

Author:

helen

Message:

Prevent an unseemly gap on the edit screen when nothing else displays before normal meta boxes. Give better HTML and visual structure to items added via edit_form_after_title and edit_form_after_editor. Using a class of .edit-form-section will now get you a 20px bottom margin; perfect for your additions to the post edit screen. fixes #23240.

Location:

trunk/wp-admin

Files:

• css/wp-admin.css (modified) (3 diffs)
• edit-form-advanced.php (modified) (4 diffs)
• includes/media.php (modified) (1 diff)

trunk/wp-admin/css/wp-admin.css

@@ -3102 +3102 @@
 }
 
-.post-formats-fields {
-    margin-bottom: 20px;
-}
-
 .wp-format-standard .post-formats-fields,
 .wp-format-aside .post-formats-fields,
@@ -4770 +4766 @@
     margin-bottom: 8px;
     padding: 2px 10px;
-}
-
-.wp_attachment_details {
-    margin-bottom: 20px;
 }
 
@@ -6326 +6318 @@
 }
 
-#post-body-content {
+.edit-form-section {
     margin-bottom: 20px;
 }

trunk/wp-admin/edit-form-advanced.php

@@ -385 +385 @@
 }
 
-do_action( 'edit_form_after_title' );
+if ( has_action( 'edit_form_after_title' ) ) {
+    echo '<div class="edit-form-section">';
+    do_action( 'edit_form_after_title' );
+    echo '</div>';
+}
 
 // post format fields
@@ -396 +400 @@
     $image = false;
 ?>
-<div class="post-formats-fields">
+<div class="post-formats-fields edit-form-section">
 
 <input type="hidden" name="post_format" id="post_format" value="<?php echo esc_attr( $post_format ); ?>" />
@@ -448 +452 @@
 if ( post_type_supports($post_type, 'editor') ) {
 ?>
-<div id="postdivrich" class="postarea">
+<div id="postdivrich" class="postarea edit-form-section">
 
 <?php wp_editor($post->post_content, 'content', array('dfw' => true, 'tabfocus_elements' => 'insert-media-button,save-post', 'editor_height' => 360) ); ?>
@@ -471 +475 @@
 
 </div>
-<?php } ?>
-
-<?php do_action( 'edit_form_after_editor' ); ?>
+<?php }
+
+if ( has_action( 'edit_form_after_editor' ) ) {
+    echo '<div class="edit-form-section">';
+    do_action( 'edit_form_after_editor' );
+    echo '</div>';
+}
+?>
 </div><!-- /post-body-content -->
 

trunk/wp-admin/includes/media.php

@@ -2308 +2308 @@
     <?php endif; ?>
 
-    <div class="wp_attachment_details">
+    <div class="wp_attachment_details edit-form-section">
         <p>
             <label for="attachment_caption"><strong><?php _e( 'Caption' ); ?></strong></label><br />