Changeset 23634

Timestamp:

03/07/2013 06:00:16 AM (12 years ago)

Author:

SergeyBiryukov

Message:

When adding a new user in the admin, strip slashes from the password sent to the user by email. props hakre for initial patch. fixes #17018.

File:

• trunk/wp-admin/includes/user.php (modified) (4 diffs)

trunk/wp-admin/includes/user.php

@@ -45 +45 @@
     $pass1 = $pass2 = '';
     if ( isset( $_POST['pass1'] ))
-        $pass1 = $_POST['pass1'];
+        $pass1 = wp_unslash( $_POST['pass1'] );
     if ( isset( $_POST['pass2'] ))
-        $pass2 = $_POST['pass2'];
+        $pass2 = wp_unslash( $_POST['pass2'] );
 
     if ( isset( $_POST['role'] ) && current_user_can( 'edit_users' ) ) {
@@ -107 +107 @@
     /* checking that username has been typed */
     if ( $user->user_login == '' )
-        $errors->add( 'user_login', __( '<strong>ERROR</strong>: Please enter a username.' ));
+        $errors->add( 'user_login', __( '<strong>ERROR</strong>: Please enter a username.' ) );
 
     /* checking the password has been typed twice */
-    do_action_ref_array( 'check_passwords', array ( $user->user_login, & $pass1, & $pass2 ));
+    do_action_ref_array( 'check_passwords', array( $user->user_login, &$pass1, &$pass2 ) );
 
     if ( $update ) {
@@ -151 +151 @@
 
     // Allow plugins to return their own errors.
-    do_action_ref_array('user_profile_update_errors', array ( &$errors, $update, &$user ) );
+    do_action_ref_array( 'user_profile_update_errors', array( &$errors, $update, &$user ) );
 
     if ( $errors->get_error_codes() )
@@ -160 +160 @@
     } else {
         $user_id = wp_insert_user( $user );
-        wp_new_user_notification( $user_id, isset($_POST['send_password']) ? $pass1 : '' );
+        wp_new_user_notification( $user_id, isset( $_POST['send_password'] ) ? $pass1 : '' );
     }
     return $user_id;