Changeset 23742

Timestamp:

03/18/2013 05:24:24 PM (12 years ago)

Author:

ryan

Message:

Don't allow changing the post format from quick edit and bulk edit. These do not have sufficient context to set the post format.

Props kovshenin
fixes #23426

Location:

trunk/wp-admin/includes

Files:

• class-wp-posts-list-table.php (modified) (1 diff)
• post.php (modified) (2 diffs)

trunk/wp-admin/includes/class-wp-posts-list-table.php

@@ -1033 +1033 @@
 
             </div>
-
-    <?php if ( post_type_supports( $screen->post_type, 'post-formats' ) && current_theme_supports( 'post-formats' ) ) :
-        $post_formats = get_theme_support( 'post-formats' );
-        if ( isset( $post_formats[0] ) && is_array( $post_formats[0] ) ) :
-            $all_post_formats = get_post_format_strings();
-            unset( $all_post_formats['standard'] ); ?>
-            <div class="inline-edit-group">
-                <label class="alignleft" for="post_format">
-                <span class="title"><?php _ex( 'Format', 'post format' ); ?></span>
-                <select name="post_format">
-                <?php if ( $bulk ) : ?>
-                    <option value="-1"><?php _e( '&mdash; No Change &mdash;' ); ?></option>
-                <?php endif; ?>
-                    <option value="0"><?php _ex( 'Standard', 'Post format' ); ?></option>
-                <?php foreach ( $all_post_formats as $slug => $format ) :
-                    $unsupported = ! in_array( $slug, $post_formats[0] );
-                    if ( $bulk && $unsupported )
-                        continue;
-                    ?>
-                    <option value="<?php echo esc_attr( $slug ); ?>"<?php if ( $unsupported ) echo ' class="unsupported"'; ?>><?php echo esc_html( $format ); ?></option>
-                <?php endforeach; ?>
-                </select></label>
-            </div>
-        <?php endif; ?>
-    <?php endif; // post-formats ?>
-
         </div></fieldset>
 

trunk/wp-admin/includes/post.php

@@ -353 +353 @@
     }
 
-    if ( isset( $post_data['post_format'] ) ) {
-        if ( '0' == $post_data['post_format'] )
-            $post_data['post_format'] = false;
-        // don't change the post format if it's not supported or not '0' (standard)
-        elseif ( ! current_theme_supports( 'post-formats', $post_data['post_format'] ) )
-            unset( $post_data['post_format'] );
-    }
-
     $updated = $skipped = $locked = array();
     foreach ( $post_IDs as $post_ID ) {
@@ -410 +402 @@
                 unstick_post( $post_ID );
         }
-
-        if ( isset( $post_data['post_format'] ) )
-            set_post_format( $post_ID, $post_data['post_format'] );
     }