Changeset 23871

Timestamp:

03/29/2013 08:39:54 PM (12 years ago)

Author:

markjaquith

Message:

Add "Customize" as first item under Appearance menu.

fixes #21413. props ryanhellyer, obenland, DrewAPicture

Location:

trunk/wp-admin

Files:

• css/wp-admin-rtl.css (modified) (1 diff)
• css/wp-admin.css (modified) (3 diffs)
• includes/menu.php (modified) (1 diff)
• menu-header.php (modified) (5 diffs)
• menu.php (modified) (1 diff)
• themes.php (modified) (2 diffs)

trunk/wp-admin/css/wp-admin-rtl.css

@@ -1339 +1339 @@
 }
 
+.theme-options span {
+    float: right;
+    margin-right: 0;
+    margin-left: 10px;
+}
+
+.theme-options ul,
 .theme-options .load-customize {
-    margin-right: 0;
-    margin-left: 30px;
-    float: right;
-}
-
-.theme-options span {
-    float: right;
-    margin-right: 0;
-    margin-left: 10px;
-}
-
-.theme-options ul {
     float: right;
 }

trunk/wp-admin/css/wp-admin.css

@@ -5548 +5548 @@
 }
 
-.theme-options .load-customize {
-    margin-right: 30px;
-    float: left;
-}
-
 .theme-options span {
     float: left;
@@ -5562 +5557 @@
 }
 
-.theme-options ul {
+.theme-options ul,
+.theme-options .load-customize {
     float: left;
     margin: 0;
@@ -6492 +6488 @@
 .no-customize-support .wp-core-ui .hide-if-no-customize,
 .customize-support.wp-core-ui .hide-if-customize,
-.customize-support .wp-core-ui .hide-if-customize {
+.customize-support .wp-core-ui .hide-if-customize,
+.no-customize-support .theme-options ul li:first-child {
     display: none;
 }

trunk/wp-admin/includes/menu.php

@@ -74 +74 @@
     // If the first submenu is not the same as the assigned parent,
     // make the first submenu the new parent.
-    if ( $new_parent != $old_parent ) {
+    if ( $new_parent != $old_parent && 'customize.php' != $new_parent ) {
         $_wp_real_parent_file[$old_parent] = $new_parent;
         $menu[$id][2] = $new_parent;

trunk/wp-admin/menu-header.php

@@ -54 +54 @@
             $submenu_items = $submenu[$item[2]];
         }
-
+        
         if ( ( $parent_file && $item[2] == $parent_file ) || ( empty($typenow) && $self == $item[2] ) ) {
             $class[] = ! empty( $submenu_items ) ? 'wp-has-current-submenu wp-menu-open' : 'current';
@@ -83 +83 @@
             echo '<div class="separator"></div>';
         } elseif ( $submenu_as_parent && ! empty( $submenu_items ) ) {
-            $submenu_items = array_values( $submenu_items );  // Re-index.
+            $temp_submenu_items = $submenu_items = array_values( $submenu_items );  // Re-index.
+            if ( 'customize.php' == $submenu_items[0][2] )
+                $submenu_items[0][2] = 'themes.php';
             $menu_hook = get_plugin_page_hook( $submenu_items[0][2], $item[2] );
             $menu_file = $submenu_items[0][2];
@@ -94 +96 @@
                 echo "\n\t<a href='{$submenu_items[0][2]}'$class $aria_attributes>$arrow<div class='wp-menu-image'>$img</div><div class='wp-menu-name'>$title</div></a>";
             }
+            $submenu_items = $temp_submenu_items;
         } elseif ( ! empty( $item[2] ) && current_user_can( $item[1] ) ) {
             $menu_hook = get_plugin_page_hook( $item[2], 'admin.php' );
@@ -106 +109 @@
             }
         }
-
+        
         if ( ! empty( $submenu_items ) ) {
             echo "\n\t<ul class='wp-submenu wp-submenu-wrap'>";
@@ -141 +144 @@
                     $class[] = 'current';
                 }
+                
+                if ( ! empty( $sub_item[3] ) )
+                    $class[] = $sub_item[3];
 
                 $class = $class ? ' class="' . join( ' ', $class ) . '"' : '';

trunk/wp-admin/menu.php

@@ -137 +137 @@
 $menu[59] = array( '', 'read', 'separator2', '', 'wp-menu-separator' );
 
-if ( current_user_can( 'switch_themes') ) {
-    $menu[60] = array( __('Appearance'), 'switch_themes', 'themes.php', '', 'menu-top menu-icon-appearance', 'menu-appearance', 'none' );
-        $submenu['themes.php'][5]  = array(__('Themes'), 'switch_themes', 'themes.php');
-        if ( current_theme_supports( 'menus' ) || current_theme_supports( 'widgets' ) )
-            $submenu['themes.php'][10] = array(__('Menus'), 'edit_theme_options', 'nav-menus.php');
-} else {
-    $menu[60] = array( __('Appearance'), 'edit_theme_options', 'themes.php', '', 'menu-top menu-icon-appearance', 'menu-appearance', 'none' );
-        $submenu['themes.php'][5]  = array(__('Themes'), 'edit_theme_options', 'themes.php');
-        if ( current_theme_supports( 'menus' ) || current_theme_supports( 'widgets' ) )
-            $submenu['themes.php'][10] = array(__('Menus'), 'edit_theme_options', 'nav-menus.php' );
-}
+$appearance_cap = current_user_can( 'switch_themes') ? 'switch_themes' : 'edit_theme_options';
+ 
+$menu[60] = array( __('Appearance'), $appearance_cap, 'themes.php', '', 'menu-top menu-icon-appearance', 'menu-appearance', 'div' );
+    $submenu['themes.php'][4] = array( __( 'Customize' ), $appearance_cap, 'customize.php', 'hide-if-no-customize' ); 
+    $submenu['themes.php'][5] = array(__( 'Themes' ), $appearance_cap, 'themes.php');
+    if ( current_theme_supports( 'menus' ) || current_theme_supports( 'widgets' ) )
+        $submenu['themes.php'][10] = array(__( 'Menus' ), 'edit_theme_options', 'nav-menus.php');
+
+unset( $appearance_cap );
 
 // Add 'Editor' to the bottom of the Appearance menu.

trunk/wp-admin/themes.php

@@ -162 +162 @@
             if ( 'themes.php' == $item[2] || 'theme-editor.php' == $item[2] )
                 continue;
+            if ( 'customize.php' == $item[2] ) {
+                if ( current_user_can( 'edit_theme_options' ) )
+                    $class = ' class="load-customize hide-if-no-customize"';
+                else
+                    continue;
+            }
             // 0 = name, 1 = capability, 2 = file
             if ( ( strcmp($self, $item[2]) == 0 && empty($parent_file)) || ($parent_file && ($item[2] == $parent_file)) )
@@ -188 +194 @@
     ?>
     <div class="theme-options">
-        <?php if ( current_user_can( 'edit_theme_options' ) ) : ?>
-        <a id="customize-current-theme-link" href="<?php echo wp_customize_url(); ?>" class="load-customize hide-if-no-customize" title="<?php echo esc_attr( $customize_title ); ?>"><?php _e( 'Customize' ); ?></a>
-        <?php
-        endif; // edit_theme_options
-        if ( $options ) :
-        ?>
+        <?php if ( $options ) : ?>
         <span><?php _e( 'Options:' )?></span>
         <ul>