Changeset 23873 for trunk/wp-admin/includes/media.php

Timestamp:

03/29/2013 08:51:35 PM (12 years ago)

Author:

markjaquith

Message:

Sanity checks on image metadata to avoid warnings, etc.

fixes #23733. props wonderboymusic.

File:

• trunk/wp-admin/includes/media.php (modified) (2 diffs)

trunk/wp-admin/includes/media.php

@@ -1128 +1128 @@
     $media_dims = '';
     $meta = wp_get_attachment_metadata( $post->ID );
-    if ( is_array( $meta ) && array_key_exists( 'width', $meta ) && array_key_exists( 'height', $meta ) )
+    if ( isset( $meta['width'], $meta['height'] ) )
         $media_dims .= "<span id='media-dims-$post->ID'>{$meta['width']}&nbsp;&times;&nbsp;{$meta['height']}</span> ";
     $media_dims = apply_filters( 'media_meta', $media_dims, $post );
@@ -2369 +2369 @@
     $media_dims = '';
     $meta = wp_get_attachment_metadata( $post->ID );
-    if ( is_array( $meta ) && array_key_exists( 'width', $meta ) && array_key_exists( 'height', $meta ) )
+    if ( isset( $meta['width'], $meta['height'] ) )
         $media_dims .= "<span id='media-dims-$post->ID'>{$meta['width']}&nbsp;&times;&nbsp;{$meta['height']}</span> ";
     $media_dims = apply_filters( 'media_meta', $media_dims, $post );