Changeset 23978

Timestamp:

04/12/2013 10:22:41 PM (13 years ago)

Author:

markjaquith

Message:

Fix some Skype chat parsing issues.

props wonderboymusic. see #23625.

File:

• trunk/wp-includes/post-formats.php (modified) (6 diffs)

trunk/wp-includes/post-formats.php

@@ -454 +454 @@
 }
 add_chat_detection_format( 'IM', '#^([^:]+):#', '#[:]#' );
-add_chat_detection_format( 'Skype', '#^(\[.+?\])\s([^:]+):#', '#[:]#' );
+add_chat_detection_format( 'Skype', '#(\[.+?\])\s([^:]+):#', '#[:]#' );
 
 /**
@@ -493 +493 @@
         global $_wp_chat_parsers;
 
-        $trimmed = trim( $content );
+        $trimmed = strip_tags( trim( $content ) );
         if ( empty( $trimmed ) )
                 return array();
@@ -513 +513 @@
         $author = $time = '';
         $lines = explode( "\n", make_clickable( $trimmed ) );
-
+        $found = false;
+        $found_index = 0;
 
         foreach ( $lines as $index => $line ) {
+                if ( ! $found )
+                        $found_index = $index;
+
                 $line = trim( $line );
 
-                if ( empty( $line ) ) {
+                if ( empty( $line ) && $found ) {
                         if ( ! empty( $author ) ) {
                                 $stanza[] = array(
@@ -528 +532 @@
 
                         $stanzas[] = $stanza;
-                        $last_index = $index;
+
                         $stanza = $data = array();
                         $author = $time = '';
@@ -539 +543 @@
                 $matches = array();
                 $matched = preg_match( $newline_regex, $line, $matches );
+                if ( ! $matched )
+                        continue;
+
+                $found = true;
+                $last_index = $index;
                 $author_match = empty( $matches[2] ) ? $matches[1] : $matches[2];
                 // assume username syntax if no whitespace is present
@@ -573 +582 @@
                 $stanzas[] = $stanza;
 
-        if ( $remove )
-                $content = trim( join( "\n", array_slice( $lines, $last_index ) ) );
+        if ( $remove ) {
+                if ( 0 === $found_index ) {
+                        $removed = array_slice( $lines, $last_index );
+                } else {
+                        $before = array_slice( $lines, 0, $found_index );
+                        $after = array_slice( $lines, $last_index + 1 );
+                        $removed = array_filter( array_merge( $before, $after ) );
+                }
+                $content = trim( join( "\n", $removed ) );
+        }
 
         return $stanzas;