Changeset 23994

Timestamp:

04/15/2013 06:40:17 PM (13 years ago)

Author:

ocean90

Message:

Revisions UI: Remove the "To:" prefix from the header when viewing a single revision. Also prefix a revision field with a label.

props SergeyBiryukov, adamsilverstein, faishal. fixes #23903.

Location:

trunk/wp-admin

Files:

• css/colors-classic.css (modified) (1 diff)
• css/colors-fresh.css (modified) (1 diff)
• css/wp-admin.css (modified) (4 diffs)
• includes/ajax-actions.php (modified) (2 diffs)
• revision.php (modified) (1 diff)

trunk/wp-admin/css/colors-classic.css

@@ -1494 +1494 @@
 .revision-tick.loading-false {
         background-color: #aaa;
+}
+
+.diff-label {
+        color: #666;
 }
 

trunk/wp-admin/css/colors-fresh.css

@@ -1397 +1397 @@
 .revision-tick.loading-false {
         background-color: #aaa;
+}
+
+.diff-label {
+        color: #666;
 }
 

trunk/wp-admin/css/wp-admin.css

@@ -3613 +3613 @@
 }
 
+#diff-title-to strong {
+        display: none;
+}
+
+.comparing-two-revisions #diff-title-to strong {
+        display: inline;
+}
+
 .diff-slider-ticks-wrapper {
         margin: 0 auto;
@@ -3624 +3632 @@
 }
 
+.diff-label {
+        margin: 20px 0 5px;
+        padding-left: 3px;
+        font-size: 13px;
+}
+
 .diff-header {
         height: 35px;
@@ -3643 +3657 @@
 .diff-title img {
         vertical-align: middle;
+        margin-left: 5px;
 }
 
@@ -3649 +3664 @@
 }
 
-.diff-col-titles {
-        font-size: 16px;
-        width: 100%;
-        margin: 20px 0 10px;
-}
-
-.diff-col-title-added,
-.diff-col-title-removed {
-        width: auto;
-        text-align: left;
-        float: left;
-        width: 48%;
-}
-
-.diff-col-title-added span,
-.diff-col-title-removed span {
-        padding: .5em;
-}
-
-.diff-col-title-added {
-        float: right;
-        color: #00a100;
-}
-
-.diff-col-title-removed {
-        color: #d2281f;
+#diff-table {
+        margin-top: 20px;
 }
 

trunk/wp-admin/includes/ajax-actions.php

@@ -2136 +2136 @@
                 $content = '';
                 //compare from left to right, passed from application
-                foreach ( array_keys( _wp_post_revision_fields() ) as $field ) {
+                foreach ( _wp_post_revision_fields() as $field => $field_value ) {
                         $left_content = apply_filters( "_wp_post_revision_field_$field", $left_revision->$field, $field, $left_revision, 'left' );
                         $right_content = apply_filters( "_wp_post_revision_field_$field", $right_revision->$field, $field, $right_revision, 'right' );
@@ -2150 +2150 @@
                         $diff = wp_text_diff_with_count( ( 0 == $compare_to ) ? '' : $left_content, $right_content, $args );
 
-                        if ( isset( $diff[ 'html' ] ) )
+                        if ( isset( $diff[ 'html' ] ) ) {
+                                $content .= sprintf( '<div class="diff-label">%s</div>', $field_value );
                                 $content .= $diff[ 'html' ];
+                        }
 
                         if ( isset( $diff[ 'lines_added' ] ) )

trunk/wp-admin/revision.php

@@ -142 +142 @@
         </div>
 
-        <div class="diff-col-titles">
-                <div class="diff-col-title-removed"><span><?php _e( 'Removed -' ); ?></span></div>
-                <div class="diff-col-title-added"><span><?php _e( 'Added +' ); ?></span></div>
-                <div class="clear"></div>
-        </div>
-
-        <div>{{{ data.diff }}}</div>
+        <div id="diff-table">{{{ data.diff }}}</div>
 </script>