Changeset 24020

Timestamp:

04/17/2013 08:12:25 PM (13 years ago)

Author:

ocean90

Message:

Revisions UI: Disable previous and next buttons when you're on the first, and last node. Put revision ticks above the slider range. props lessbloat for initial patch. see #23899.

Location:

trunk/wp-admin

Files:

• css/colors-classic.css (modified) (1 diff)
• css/colors-fresh.css (modified) (1 diff)
• css/wp-admin.css (modified) (1 diff)
• js/revisions.js (modified) (3 diffs)

trunk/wp-admin/css/colors-classic.css

@@ -1492 +1492 @@
 
 .revision-tick.completed-true {
-        background-color: #aaa;
+        background-color: #d1e5ee;
 }
 

trunk/wp-admin/css/colors-fresh.css

@@ -1386 +1386 @@
 
 .revision-tick.completed-true {
-        background-color: #aaa;
+        background-color: #d7d7d7;
 }
 

trunk/wp-admin/css/wp-admin.css

@@ -3629 +3629 @@
 #diff-slider-ticks {
         position: absolute;
-        z-index: 1;
+        z-index: 2;
         margin-top: 20px;
 }

trunk/wp-admin/js/revisions.js

@@ -244 +244 @@
                 },
 
+                disabledButtonCheck: function( val ) {
+                        var maxVal = this.revisions.length - 1,
+                                next = $( '#next' ),
+                                prev = $( '#previous' );
+
+                        // Disable "Next" button if you're on the last node
+                        if ( maxVal === val )
+                                next.prop( 'disabled', true );
+                        else
+                                next.prop( 'disabled', false );
+
+                        // Disable "Previous" button if you're on the 0 node
+                        if ( 0 === val )
+                                prev.prop( 'disabled', true );
+                        else
+                                prev.prop( 'disabled', false );
+                },
+
                 completeApplicationSetup: function() {
                         this.revisionView = new revisions.view.Diff({
@@ -294 +312 @@
                                 Diff.rightDiff = ( ui.value + 1 );
                                 Diff.revisionView.render();
+                                Diff.disabledButtonCheck( ui.value );
                         } else {
                                 if ( ui.values[0] === ui.values[1] ) // prevent compare to self
@@ -417 +436 @@
                         if ( slide )
                                 $( '#diff-slider' ).trigger( 'slide' );
+
+                        Diff.disabledButtonCheck( options.value );
                 },