Changeset 24129

Timestamp:

04/29/2013 02:48:31 PM (12 years ago)

Author:

nacin

Message:

Variables passed by reference do not need to be set first.

props kovshenin.
see #24222.

Location:

trunk/wp-includes

Files:

• formatting.php (modified) (1 diff)
• media.php (modified) (7 diffs)
• post-formats.php (modified) (4 diffs)
• post-template.php (modified) (1 diff)
• shortcodes.php (modified) (1 diff)

trunk/wp-includes/formatting.php

@@ -3265 +3265 @@
     }
 
-    $match = array();
     $found = false;
     while ( preg_match('/%[a-f0-9]{2}/i', $filtered, $match) ) {

trunk/wp-includes/media.php

@@ -1909 +1909 @@
 function get_content_media( $type, &$content, $html = true, $remove = false, $limit = 0 ) {
     $items = array();
-    $matches = array();
 
     if ( preg_match_all( '/' . get_shortcode_regex() . '/s', $content, $matches, PREG_SET_ORDER ) && ! empty( $matches ) ) {
@@ -1928 +1927 @@
         return $items;
 
-    $src = '';
     $data = array();
 
@@ -1959 +1957 @@
 function get_embedded_media( $type, &$content, $remove = false, $limit = 0 ) {
     $html = array();
-    $matches = '';
 
     foreach ( array( $type, 'object', 'embed', 'iframe' ) as $tag ) {
@@ -2207 +2204 @@
  */
 function get_content_images( &$content, $html = true, $remove = false, $limit = 0 ) {
-    $matches = array();
     $tags = array();
     $captions = array();
@@ -2256 +2252 @@
         return $tags;
 
-    $src = '';
     $srcs = array();
 
@@ -2301 +2296 @@
  */
 function get_content_galleries( &$content, $html = true, $remove = false, $limit = 0 ) {
-    $src = '';
     $galleries = array();
-    $matches = array();
 
     if ( preg_match_all( '/' . get_shortcode_regex() . '/s', $content, $matches, PREG_SET_ORDER ) && ! empty( $matches ) ) {
@@ -2494 +2487 @@
 
         $count = 1;
-        $matches = array();
         $content = $post->post_content;
 

trunk/wp-includes/post-formats.php

@@ -581 +581 @@
         }
 
-        $matches = array();
         $matched = preg_match( $newline_regex, $line, $matches );
         if ( ! $matched )
@@ -710 +709 @@
         return '';
 
-    $matches = array();
     if ( ! preg_match( '/<blockquote[^>]*>(.+?)<\/blockquote>/is', $content, $matches ) ) {
         $quote = $content;
@@ -783 +781 @@
     if ( empty( $content ) )
         return '';
-
-    $matches = array();
 
     // the content is a URL
@@ -884 +880 @@
     $output = '';
     $has_teaser = false;
-    $matches = array();
 
     // If post password required and it doesn't match the cookie.

trunk/wp-includes/post-template.php

@@ -186 +186 @@
     $output = '';
     $has_teaser = false;
-    $matches = array();
 
     // If post password required and it doesn't match the cookie.

trunk/wp-includes/shortcodes.php

@@ -153 +153 @@
 function has_shortcode( $content, $tag ) {
     if ( shortcode_exists( $tag ) ) {
-        $matches = array();
         preg_match_all( '/' . get_shortcode_regex() . '/s', $content, $matches, PREG_SET_ORDER );
         if ( empty( $matches ) )