Changeset 24131

Timestamp:

04/29/2013 04:57:30 PM (13 years ago)

Author:

lancewillett

Message:

Bundled themes: remove the_title_attribute() title attributes where it duplicates the_title() in anchor text. Props nacin, fixes #24203.

Location:

trunk/wp-content/themes

Files:

• twentyeleven/content-aside.php (modified) (1 diff)
• twentyeleven/content-featured.php (modified) (1 diff)
• twentyeleven/content-gallery.php (modified) (1 diff)
• twentyeleven/content-image.php (modified) (1 diff)
• twentyeleven/content-link.php (modified) (1 diff)
• twentyeleven/content-quote.php (modified) (1 diff)
• twentyeleven/content-status.php (modified) (1 diff)
• twentyeleven/content.php (modified) (1 diff)
• twentyeleven/inc/widgets.php (modified) (2 diffs)
• twentyeleven/showcase.php (modified) (1 diff)
• twentyten/loop.php (modified) (2 diffs)
• twentythirteen/content-audio.php (modified) (1 diff)
• twentythirteen/content-chat.php (modified) (1 diff)
• twentythirteen/content-gallery.php (modified) (1 diff)
• twentythirteen/content-image.php (modified) (1 diff)
• twentythirteen/content-link.php (modified) (1 diff)
• twentythirteen/content-video.php (modified) (1 diff)
• twentythirteen/content.php (modified) (1 diff)
• twentytwelve/content-aside.php (modified) (1 diff)
• twentytwelve/content-image.php (modified) (1 diff)
• twentytwelve/content.php (modified) (1 diff)

trunk/wp-content/themes/twentyeleven/content-aside.php

@@ -14 +14 @@
                 <header class="entry-header">
                         <hgroup>
-                                <h2 class="entry-title"><a href="<?php the_permalink(); ?>" title="<?php echo esc_attr( sprintf( __( 'Permalink to %s', 'twentyeleven' ), the_title_attribute( 'echo=0' ) ) ); ?>" rel="bookmark"><?php the_title(); ?></a></h2>
+                                <h2 class="entry-title"><a href="<?php the_permalink(); ?>" rel="bookmark"><?php the_title(); ?></a></h2>
                                 <h3 class="entry-format"><?php _e( 'Aside', 'twentyeleven' ); ?></h3>
                         </hgroup>

trunk/wp-content/themes/twentyeleven/content-featured.php

@@ -12 +12 @@
 <article id="post-<?php the_ID(); ?>" <?php post_class( $feature_class ); ?>>
         <header class="entry-header">
-                <h2 class="entry-title"><a href="<?php the_permalink(); ?>" title="<?php echo esc_attr( sprintf( __( 'Permalink to %s', 'twentyeleven' ), the_title_attribute( 'echo=0' ) ) ); ?>" rel="bookmark"><?php the_title(); ?></a></h2>
+                <h2 class="entry-title"><a href="<?php the_permalink(); ?>" rel="bookmark"><?php the_title(); ?></a></h2>
 
                 <div class="entry-meta">

trunk/wp-content/themes/twentyeleven/content-gallery.php

@@ -14 +14 @@
         <header class="entry-header">
                 <hgroup>
-                        <h2 class="entry-title"><a href="<?php the_permalink(); ?>" title="<?php echo esc_attr( sprintf( __( 'Permalink to %s', 'twentyeleven' ), the_title_attribute( 'echo=0' ) ) ); ?>" rel="bookmark"><?php the_title(); ?></a></h2>
+                        <h2 class="entry-title"><a href="<?php the_permalink(); ?>" rel="bookmark"><?php the_title(); ?></a></h2>
                         <h3 class="entry-format"><?php _e( 'Gallery', 'twentyeleven' ); ?></h3>
                 </hgroup>

trunk/wp-content/themes/twentyeleven/content-image.php

@@ -13 +13 @@
                 <header class="entry-header">
                         <hgroup>
-                                <h2 class="entry-title"><a href="<?php the_permalink(); ?>" title="<?php echo esc_attr( sprintf( __( 'Permalink to %s', 'twentyeleven' ), the_title_attribute( 'echo=0' ) ) ); ?>" rel="bookmark"><?php the_title(); ?></a></h2>
+                                <h2 class="entry-title"><a href="<?php the_permalink(); ?>" rel="bookmark"><?php the_title(); ?></a></h2>
                                 <h3 class="entry-format"><?php _e( 'Image', 'twentyeleven' ); ?></h3>
                         </hgroup>

trunk/wp-content/themes/twentyeleven/content-link.php

@@ -14 +14 @@
                 <header class="entry-header">
                         <hgroup>
-                                <h2 class="entry-title"><a href="<?php the_permalink(); ?>" title="<?php echo esc_attr( sprintf( __( 'Permalink to %s', 'twentyeleven' ), the_title_attribute( 'echo=0' ) ) ); ?>" rel="bookmark"><?php the_title(); ?></a></h2>
+                                <h2 class="entry-title"><a href="<?php the_permalink(); ?>" rel="bookmark"><?php the_title(); ?></a></h2>
                                 <h3 class="entry-format"><?php _e( 'Link', 'twentyeleven' ); ?></h3>
                         </hgroup>

trunk/wp-content/themes/twentyeleven/content-quote.php

@@ -12 +12 @@
                 <header class="entry-header">
                         <hgroup>
-                                <h2 class="entry-title"><a href="<?php the_permalink(); ?>" title="<?php echo esc_attr( sprintf( __( 'Permalink to %s', 'twentyeleven' ), the_title_attribute( 'echo=0' ) ) ); ?>" rel="bookmark"><?php the_title(); ?></a></h2>
+                                <h2 class="entry-title"><a href="<?php the_permalink(); ?>" rel="bookmark"><?php the_title(); ?></a></h2>
                                 <h3 class="entry-format"><?php _e( 'Quote', 'twentyeleven' ); ?></h3>
                         </hgroup>

trunk/wp-content/themes/twentyeleven/content-status.php

@@ -13 +13 @@
                 <header class="entry-header">
                         <hgroup>
-                                <h2 class="entry-title"><a href="<?php the_permalink(); ?>" title="<?php echo esc_attr( sprintf( __( 'Permalink to %s', 'twentyeleven' ), the_title_attribute( 'echo=0' ) ) ); ?>" rel="bookmark"><?php the_title(); ?></a></h2>
+                                <h2 class="entry-title"><a href="<?php the_permalink(); ?>" rel="bookmark"><?php the_title(); ?></a></h2>
                                 <h3 class="entry-format"><?php _e( 'Status', 'twentyeleven' ); ?></h3>
                         </hgroup>

trunk/wp-content/themes/twentyeleven/content.php

@@ -13 +13 @@
                         <?php if ( is_sticky() ) : ?>
                                 <hgroup>
-                                        <h2 class="entry-title"><a href="<?php the_permalink(); ?>" title="<?php echo esc_attr( sprintf( __( 'Permalink to %s', 'twentyeleven' ), the_title_attribute( 'echo=0' ) ) ); ?>" rel="bookmark"><?php the_title(); ?></a></h2>
+                                        <h2 class="entry-title"><a href="<?php the_permalink(); ?>" rel="bookmark"><?php the_title(); ?></a></h2>
                                         <h3 class="entry-format"><?php _e( 'Featured', 'twentyeleven' ); ?></h3>
                                 </hgroup>
                         <?php else : ?>
-                        <h1 class="entry-title"><a href="<?php the_permalink(); ?>" title="<?php echo esc_attr( sprintf( __( 'Permalink to %s', 'twentyeleven' ), the_title_attribute( 'echo=0' ) ) ); ?>" rel="bookmark"><?php the_title(); ?></a></h1>
+                        <h1 class="entry-title"><a href="<?php the_permalink(); ?>" rel="bookmark"><?php the_title(); ?></a></h1>
                         <?php endif; ?>
 

trunk/wp-content/themes/twentyeleven/inc/widgets.php

@@ -87 +87 @@
 
                                 <li class="widget-entry-title">
-                                        <a href="<?php echo esc_url( get_permalink() ); ?>" title="<?php echo esc_attr( sprintf( __( 'Permalink to %s', 'twentyeleven' ), the_title_attribute( 'echo=0' ) ) ); ?>" rel="bookmark"><?php the_title(); ?></a>
+                                        <a href="<?php echo esc_url( get_permalink() ); ?>" rel="bookmark"><?php the_title(); ?></a>
                                         <span class="comments-link">
                                                 <?php comments_popup_link( __( '0 <span class="reply">comments &rarr;</span>', 'twentyeleven' ), __( '1 <span class="reply">comment &rarr;</span>', 'twentyeleven' ), __( '% <span class="reply">comments &rarr;</span>', 'twentyeleven' ) ); ?>
@@ -96 +96 @@
 
                                 <li class="widget-entry-title">
-                                        <a href="<?php echo esc_url( twentyeleven_get_first_url() ); ?>" title="<?php echo esc_attr( sprintf( __( 'Link to %s', 'twentyeleven' ), the_title_attribute( 'echo=0' ) ) ); ?>" rel="bookmark"><?php the_title(); ?>&nbsp;<span>&rarr;</span></a>
+                                        <a href="<?php echo esc_url( twentyeleven_get_first_url() ); ?>" rel="bookmark"><?php the_title(); ?>&nbsp;<span>&rarr;</span></a>
                                         <span class="comments-link">
                                                 <?php comments_popup_link( __( '0 <span class="reply">comments &rarr;</span>', 'twentyeleven' ), __( '1 <span class="reply">comment &rarr;</span>', 'twentyeleven' ), __( '% <span class="reply">comments &rarr;</span>', 'twentyeleven' ) ); ?>

trunk/wp-content/themes/twentyeleven/showcase.php

@@ -197 +197 @@
 
                                                 <li class="entry-title">
-                                                        <a href="<?php the_permalink(); ?>" title="<?php echo esc_attr( sprintf( __( 'Permalink to %s', 'twentyeleven' ), the_title_attribute( 'echo=0' ) ) ); ?>" rel="bookmark"><?php the_title(); ?></a>
+                                                        <a href="<?php the_permalink(); ?>" rel="bookmark"><?php the_title(); ?></a>
                                                         <span class="comments-link">
                                                                 <?php comments_popup_link( '<span class="leave-reply">' . __( 'Leave a reply', 'twentyeleven' ) . '</span>', __( '<b>1</b> Reply', 'twentyeleven' ), __( '<b>%</b> Replies', 'twentyeleven' ) ); ?>

trunk/wp-content/themes/twentyten/loop.php

@@ -60 +60 @@
         <?php if ( ( function_exists( 'get_post_format' ) && 'gallery' == get_post_format( $post->ID ) ) || in_category( _x( 'gallery', 'gallery category slug', 'twentyten' ) ) ) : ?>
                 <div id="post-<?php the_ID(); ?>" <?php post_class(); ?>>
-                        <h2 class="entry-title"><a href="<?php the_permalink(); ?>" title="<?php echo esc_attr( sprintf( __( 'Permalink to %s', 'twentyten' ), the_title_attribute( 'echo=0' ) ) ); ?>" rel="bookmark"><?php the_title(); ?></a></h2>
+                        <h2 class="entry-title"><a href="<?php the_permalink(); ?>" rel="bookmark"><?php the_title(); ?></a></h2>
 
                         <div class="entry-meta">
@@ -128 +128 @@
         <?php else : ?>
                 <div id="post-<?php the_ID(); ?>" <?php post_class(); ?>>
-                        <h2 class="entry-title"><a href="<?php the_permalink(); ?>" title="<?php echo esc_attr( sprintf( __( 'Permalink to %s', 'twentyten' ), the_title_attribute( 'echo=0' ) ) ); ?>" rel="bookmark"><?php the_title(); ?></a></h2>
+                        <h2 class="entry-title"><a href="<?php the_permalink(); ?>" rel="bookmark"><?php the_title(); ?></a></h2>
 
                         <div class="entry-meta">

trunk/wp-content/themes/twentythirteen/content-audio.php

@@ -15 +15 @@
                 <?php else : ?>
                 <h1 class="entry-title">
-                        <a href="<?php the_permalink(); ?>" title="<?php echo esc_attr( sprintf( __( 'Permalink to %s', 'twentythirteen' ), the_title_attribute( 'echo=0' ) ) ); ?>" rel="bookmark"><?php the_title(); ?></a>
+                        <a href="<?php the_permalink(); ?>" rel="bookmark"><?php the_title(); ?></a>
                 </h1>
                 <?php endif; // is_single() ?>

trunk/wp-content/themes/twentythirteen/content-chat.php

@@ -15 +15 @@
                 <?php else : ?>
                 <h1 class="entry-title">
-                        <a href="<?php the_permalink(); ?>" title="<?php echo esc_attr( sprintf( __( 'Permalink to %s', 'twentythirteen' ), the_title_attribute( 'echo=0' ) ) ); ?>" rel="bookmark"><?php the_title(); ?></a>
+                        <a href="<?php the_permalink(); ?>" rel="bookmark"><?php the_title(); ?></a>
                 </h1>
                 <?php endif; // is_single() ?>

trunk/wp-content/themes/twentythirteen/content-gallery.php

@@ -15 +15 @@
                 <?php else : ?>
                 <h1 class="entry-title">
-                        <a href="<?php the_permalink(); ?>" title="<?php echo esc_attr( sprintf( __( 'Permalink to %s', 'twentythirteen' ), the_title_attribute( 'echo=0' ) ) ); ?>" rel="bookmark"><?php the_title(); ?></a>
+                        <a href="<?php the_permalink(); ?>" rel="bookmark"><?php the_title(); ?></a>
                 </h1>
                 <?php endif; // is_single() ?>

trunk/wp-content/themes/twentythirteen/content-image.php

@@ -19 +19 @@
                 <?php else : ?>
                 <h1 class="entry-title">
-                        <a href="<?php the_permalink(); ?>" title="<?php echo esc_attr( sprintf( __( 'Permalink to %s', 'twentythirteen' ), the_title_attribute( 'echo=0' ) ) ); ?>" rel="bookmark"><?php the_title(); ?></a>
+                        <a href="<?php the_permalink(); ?>" rel="bookmark"><?php the_title(); ?></a>
                 </h1>
                 <?php endif; // is_single() ?>

trunk/wp-content/themes/twentythirteen/content-link.php

@@ -12 +12 @@
         <header class="entry-header">
                 <h1 class="entry-title">
-                        <a href="<?php echo esc_url( twentythirteen_get_link_url() ); ?>" title="<?php the_title_attribute(); ?>"><?php the_title(); ?></a>
+                        <a href="<?php echo esc_url( twentythirteen_get_link_url() ); ?>"><?php the_title(); ?></a>
                 </h1>
 

trunk/wp-content/themes/twentythirteen/content-video.php

@@ -19 +19 @@
                 <?php else : ?>
                 <h1 class="entry-title">
-                        <a href="<?php the_permalink(); ?>" title="<?php echo esc_attr( sprintf( __( 'Permalink to %s', 'twentythirteen' ), the_title_attribute( 'echo=0' ) ) ); ?>" rel="bookmark"><?php the_title(); ?></a>
+                        <a href="<?php the_permalink(); ?>" rel="bookmark"><?php the_title(); ?></a>
                 </h1>
                 <?php endif; // is_single() ?>

trunk/wp-content/themes/twentythirteen/content.php

@@ -21 +21 @@
                 <?php else : ?>
                 <h1 class="entry-title">
-                        <a href="<?php the_permalink(); ?>" title="<?php echo esc_attr( sprintf( __( 'Permalink to %s', 'twentythirteen' ), the_title_attribute( 'echo=0' ) ) ); ?>" rel="bookmark"><?php the_title(); ?></a>
+                        <a href="<?php the_permalink(); ?>" rel="bookmark"><?php the_title(); ?></a>
                 </h1>
                 <?php endif; // is_single() ?>

trunk/wp-content/themes/twentytwelve/content-aside.php

@@ -11 +11 @@
         <article id="post-<?php the_ID(); ?>" <?php post_class(); ?>>
                 <div class="aside">
-                        <h1 class="entry-title"><a href="<?php the_permalink(); ?>" title="<?php echo esc_attr( sprintf( __( 'Permalink to %s', 'twentytwelve' ), the_title_attribute( 'echo=0' ) ) ); ?>" rel="bookmark"><?php the_title(); ?></a></h1>
+                        <h1 class="entry-title"><a href="<?php the_permalink(); ?>" rel="bookmark"><?php the_title(); ?></a></h1>
                         <div class="entry-content">
                                 <?php the_content( __( 'Continue reading <span class="meta-nav">&rarr;</span>', 'twentytwelve' ) ); ?>

trunk/wp-content/themes/twentytwelve/content-image.php

@@ -15 +15 @@
 
                 <footer class="entry-meta">
-                        <a href="<?php the_permalink(); ?>" title="<?php echo esc_attr( sprintf( __( 'Permalink to %s', 'twentytwelve' ), the_title_attribute( 'echo=0' ) ) ); ?>" rel="bookmark">
+                        <a href="<?php the_permalink(); ?>" rel="bookmark">
                                 <h1><?php the_title(); ?></h1>
                                 <h2><time class="entry-date" datetime="<?php echo esc_attr( get_the_date( 'c' ) ); ?>"><?php echo get_the_date(); ?></time></h2>

trunk/wp-content/themes/twentytwelve/content.php

@@ -21 +21 @@
                         <?php else : ?>
                         <h1 class="entry-title">
-                                <a href="<?php the_permalink(); ?>" title="<?php echo esc_attr( sprintf( __( 'Permalink to %s', 'twentytwelve' ), the_title_attribute( 'echo=0' ) ) ); ?>" rel="bookmark"><?php the_title(); ?></a>
+                                <a href="<?php the_permalink(); ?>" rel="bookmark"><?php the_title(); ?></a>
                         </h1>
                         <?php endif; // is_single() ?>