Changeset 24249 for trunk/wp-includes/media.php

Timestamp:

05/14/2013 01:57:59 PM (12 years ago)

Author:

ryan

Message:

Remove redundant post ID validation.

Props SergeyBiryukov
fixes #24199

File:

• trunk/wp-includes/media.php (modified) (4 diffs)

trunk/wp-includes/media.php

@@ -1851 +1851 @@
  */
 function get_attached_media( $type, $post_id = 0 ) {
-    $post = empty( $post_id ) ? get_post() : get_post( $post_id );
-    if ( empty( $post ) )
+    if ( ! $post = get_post( $post_id ) )
         return;
 
@@ -2341 +2340 @@
  */
 function get_post_galleries( $post_id = 0, $html = true ) {
-    $post = empty( $post_id ) ? clone get_post() : get_post( $post_id );
-    if ( empty( $post ) || ! has_shortcode( $post->post_content, 'gallery' )  )
+    if ( ! $post = get_post( $post_id ) )
+        return array();
+
+    if ( ! has_shortcode( $post->post_content, 'gallery' )  )
         return array();
 
@@ -2358 +2359 @@
  */
 function get_post_galleries_images( $post_id = 0 ) {
-    $post = empty( $post_id ) ? clone get_post() : get_post( $post_id );
-    if ( empty( $post ) || ! has_shortcode( $post->post_content, 'gallery' )  )
+    if ( ! $post = get_post( $post_id ) )
+        return array();
+
+    if ( ! has_shortcode( $post->post_content, 'gallery' )  )
         return array();
 
@@ -2376 +2379 @@
  */
 function get_post_gallery( $post_id = 0, $html = true ) {
-    $post = empty( $post_id ) ? clone get_post() : get_post( $post_id );
-    if ( empty( $post ) || ! has_shortcode( $post->post_content, 'gallery' ) )
+    if ( ! $post = get_post( $post_id ) )
+        return array();
+
+    if ( ! has_shortcode( $post->post_content, 'gallery' ) )
         return array();