Changeset 24474 for trunk/wp-admin/update.php

Timestamp:

06/21/2013 05:54:40 AM (12 years ago)

Author:

nacin

Message:

More robust escaping in the plugin/theme upgrader.

File:

• trunk/wp-admin/update.php (modified) (7 diffs)

trunk/wp-admin/update.php

@@ -58 +58 @@
 
         $nonce = 'upgrade-plugin_' . $plugin;
-        $url = 'update.php?action=upgrade-plugin&plugin=' . $plugin;
+        $url = 'update.php?action=upgrade-plugin&plugin=' . urlencode( $plugin );
 
         $upgrader = new Plugin_Upgrader( new Plugin_Upgrader_Skin( compact('title', 'nonce', 'url', 'plugin') ) );
@@ -71 +71 @@
         check_admin_referer('activate-plugin_' . $plugin);
         if ( ! isset($_GET['failure']) && ! isset($_GET['success']) ) {
-            wp_redirect( admin_url('update.php?action=activate-plugin&failure=true&plugin=' . $plugin . '&_wpnonce=' . $_GET['_wpnonce']) );
+            wp_redirect( admin_url('update.php?action=activate-plugin&failure=true&plugin=' . urlencode( $plugin ) . '&_wpnonce=' . $_GET['_wpnonce']) );
             activate_plugin( $plugin, '', ! empty( $_GET['networkwide'] ), true );
-            wp_redirect( admin_url('update.php?action=activate-plugin&success=true&plugin=' . $plugin . '&_wpnonce=' . $_GET['_wpnonce']) );
+            wp_redirect( admin_url('update.php?action=activate-plugin&success=true&plugin=' . urlencode( $plugin ) . '&_wpnonce=' . $_GET['_wpnonce']) );
             die();
         }
@@ -108 +108 @@
         $title = sprintf( __('Installing Plugin: %s'), $api->name . ' ' . $api->version );
         $nonce = 'install-plugin_' . $plugin;
-        $url = 'update.php?action=install-plugin&plugin=' . $plugin;
+        $url = 'update.php?action=install-plugin&plugin=' . urlencode( $plugin );
         if ( isset($_GET['from']) )
             $url .= '&from=' . urlencode(stripslashes($_GET['from']));
@@ -133 +133 @@
         require_once(ABSPATH . 'wp-admin/admin-header.php');
 
-        $title = sprintf( __('Installing Plugin from uploaded file: %s'), basename( $file_upload->filename ) );
+        $title = sprintf( __('Installing Plugin from uploaded file: %s'), esc_html( basename( $file_upload->filename ) ) );
         $nonce = 'plugin-upload';
         $url = add_query_arg(array('package' => $file_upload->id), 'update.php?action=upload-plugin');
@@ -161 +161 @@
 
         $nonce = 'upgrade-theme_' . $theme;
-        $url = 'update.php?action=upgrade-theme&theme=' . $theme;
+        $url = 'update.php?action=upgrade-theme&theme=' . urlencode( $theme );
 
         $upgrader = new Theme_Upgrader( new Theme_Upgrader_Skin( compact('title', 'nonce', 'url', 'theme') ) );
@@ -214 +214 @@
         $title = sprintf( __('Installing Theme: %s'), $api->name . ' ' . $api->version );
         $nonce = 'install-theme_' . $theme;
-        $url = 'update.php?action=install-theme&theme=' . $theme;
+        $url = 'update.php?action=install-theme&theme=' . urlencode( $theme );
         $type = 'web'; //Install theme type, From Web or an Upload.
 
@@ -239 +239 @@
         require_once(ABSPATH . 'wp-admin/admin-header.php');
 
-        $title = sprintf( __('Installing Theme from uploaded file: %s'), basename( $file_upload->filename ) );
+        $title = sprintf( __('Installing Theme from uploaded file: %s'), esc_html( basename( $file_upload->filename ) ) );
         $nonce = 'theme-upload';
         $url = add_query_arg(array('package' => $file_upload->id), 'update.php?action=upload-theme');