Changeset 24556

Timestamp:

07/04/2013 08:30:36 AM (12 years ago)

Author:

markjaquith

Message:

Debounce the Revisions UI URL updates as you scrub, for a massive speedup and a reduction in URL history detritus.

see #24425

File:

• trunk/wp-admin/js/revisions.js (modified) (5 diffs)

trunk/wp-admin/js/revisions.js

@@ -196 +196 @@
             this.listenTo( this, 'change:from', this.updateDiffFrom );
             this.listenTo( this, 'change:to', this.updateDiffTo );
-            this.revisionsRouter = new revisions.router.Router();
-            this.revisionsRouter.model = this;
+            this.revisionsRouter = new revisions.router.Router({ model: this });
         },
 
         updateDiffTo: function() {
             var from = this.get( 'from' );
-            var to   = this.get( 'to' );
-            this.set( 'diffId', (from ? from.id : '0' ) + ':' + to.id );
+            this.set( 'diffId', (from ? from.id : '0' ) + ':' + this.get('to').id );
         },
 
@@ -269 +267 @@
                     model: diff
                 }));
+                this.model.trigger( 'renderDiff' );
             });
         }
@@ -685 +684 @@
             }
             this.model.set( attributes );
-
-            // Maintain state history when dragging
-            this.model.revisionsRouter.navigateRoute( attributes.to.id, ( attributes.from ? attributes.from.id : 0 ) );
         },
 
@@ -718 +714 @@
     // takes URLs with #hash fragments and routes them
     revisions.router.Router = Backbone.Router.extend({
-        model: null,
+        initialize: function( options ) {
+            this.model = options.model;
+
+            // Maintain state history when dragging
+            this.listenTo( this.model, 'renderDiff', this.updateURL );
+        },
 
         routes: {
@@ -733 +734 @@
             this.navigate( navigateTo );
         },
+
+        updateURL: _.debounce( function() {
+            var from = this.model.get('from');
+            this.navigateRoute( this.model.get('to').id, from ? from.id : 0 );
+        }, 250 ),
 
         gotoRevisionId: function( from, to, handles ) {