Changeset 24583

Timestamp:

07/08/2013 01:04:07 PM (11 years ago)

Author:

nacin

Message:

Revert [23394] until there is a consensus on target="_blank" (or not) for these external links. see #20839.

Location:

trunk

Files:

• wp-admin/includes/class-wp-ms-themes-list-table.php (modified) (1 diff)
• wp-admin/includes/class-wp-plugins-list-table.php (modified) (1 diff)
• wp-admin/includes/plugin.php (modified) (1 diff)
• wp-includes/class-wp-theme.php (modified) (1 diff)

trunk/wp-admin/includes/class-wp-ms-themes-list-table.php

@@ -332 +332 @@
 
                     if ( $theme->get('ThemeURI') )
-                        $theme_meta[] = '<a href="' . $theme->display('ThemeURI') . '" title="' . esc_attr__( 'Visit theme homepage' ) . '" target="_blank">' . __( 'Visit Theme Site' ) . '</a>';
+                        $theme_meta[] = '<a href="' . $theme->display('ThemeURI') . '" title="' . esc_attr__( 'Visit theme homepage' ) . '">' . __( 'Visit Theme Site' ) . '</a>';
 
                     $theme_meta = apply_filters( 'theme_row_meta', $theme_meta, $stylesheet, $theme, $status );

trunk/wp-admin/includes/class-wp-plugins-list-table.php

@@ -412 +412 @@
                         $author = $plugin_data['Author'];
                         if ( !empty( $plugin_data['AuthorURI'] ) )
-                            $author = '<a href="' . $plugin_data['AuthorURI'] . '" title="' . esc_attr__( 'Visit author homepage' ) . '" target="_blank">' . $plugin_data['Author'] . '</a>';
+                            $author = '<a href="' . $plugin_data['AuthorURI'] . '" title="' . esc_attr__( 'Visit author homepage' ) . '">' . $plugin_data['Author'] . '</a>';
                         $plugin_meta[] = sprintf( __( 'By %s' ), $author );
                     }
                     if ( ! empty( $plugin_data['PluginURI'] ) )
-                        $plugin_meta[] = '<a href="' . $plugin_data['PluginURI'] . '" title="' . esc_attr__( 'Visit plugin site' ) . '" target="_blank">' . __( 'Visit plugin site' ) . '</a>';
+                        $plugin_meta[] = '<a href="' . $plugin_data['PluginURI'] . '" title="' . esc_attr__( 'Visit plugin site' ) . '">' . __( 'Visit plugin site' ) . '</a>';
 
                     $plugin_meta = apply_filters( 'plugin_row_meta', $plugin_meta, $plugin_file, $plugin_data, $status );

trunk/wp-admin/includes/plugin.php

@@ -158 +158 @@
     if ( $markup ) {
         if ( $plugin_data['PluginURI'] && $plugin_data['Name'] )
-            $plugin_data['Title'] = '<a href="' . $plugin_data['PluginURI'] . '" title="' . esc_attr__( 'Visit plugin homepage' ) . '" target="_blank">' . $plugin_data['Name'] . '</a>';
+            $plugin_data['Title'] = '<a href="' . $plugin_data['PluginURI'] . '" title="' . esc_attr__( 'Visit plugin homepage' ) . '">' . $plugin_data['Name'] . '</a>';
 
         if ( $plugin_data['AuthorURI'] && $plugin_data['Author'] )
-            $plugin_data['Author'] = '<a href="' . $plugin_data['AuthorURI'] . '" title="' . esc_attr__( 'Visit author homepage' ) . '" target="_blank">' . $plugin_data['Author'] . '</a>';
+            $plugin_data['Author'] = '<a href="' . $plugin_data['AuthorURI'] . '" title="' . esc_attr__( 'Visit author homepage' ) . '">' . $plugin_data['Author'] . '</a>';
 
         $plugin_data['Description'] = wptexturize( $plugin_data['Description'] );

trunk/wp-includes/class-wp-theme.php

@@ -653 +653 @@
                     if ( ! isset( $attr ) )
                         $attr = esc_attr__( 'Visit author homepage' );
-                    $value = sprintf( '<a href="%1$s" title="%2$s" target="_blank">%3$s</a>', $this->display( 'AuthorURI', true, $translate ), $attr, $value );
+                    $value = sprintf( '<a href="%1$s" title="%2$s">%3$s</a>', $this->display( 'AuthorURI', true, $translate ), $attr, $value );
                 } elseif ( ! $value ) {
                     $value = __( 'Anonymous' );