Changeset 24585

Timestamp:

07/08/2013 01:55:50 PM (8 years ago)

Author:

nacin

Message:

Use wp_basename() in newer media code for filenames to avoid encoding issues on display. props SergeyBiryukov, fixes #23267.

Location:

trunk

Files:

• wp-admin/includes/media.php (modified) (1 diff)
• wp-includes/media.php (modified) (1 diff)

trunk/wp-admin/includes/media.php

@@ -2424 +2424 @@
     $post = get_post();
 
-    $filename = esc_html( basename( $post->guid ) );
+    $filename = esc_html( wp_basename( $post->guid ) );
 
     $media_dims = '';

trunk/wp-includes/media.php

@@ -1607 +1607 @@
         'id'          => $attachment->ID,
         'title'       => $attachment->post_title,
-        'filename'    => basename( $attachment->guid ),
+        'filename'    => wp_basename( $attachment->guid ),
         'url'         => $attachment_url,
         'link'        => get_attachment_link( $attachment->ID ),