Changeset 24615

Timestamp:

07/09/2013 07:21:25 PM (10 years ago)

Author:

markjaquith

Message:

Pass back dateUnix (a unix timestamp) for better sorting of revisions in Backbone.

Props duck_. See #24425.

Location:

trunk/wp-admin

Files:

• includes/revision.php (modified) (1 diff)
• js/revisions.js (modified) (2 diffs)

trunk/wp-admin/includes/revision.php

@@ -91 +91 @@
             'date'         => date_i18n( __( 'M j, Y @ G:i' ), $modified_gmt ),
             'dateShort'    => date_i18n( _x( 'j M @ G:i', 'revision date short format' ), $modified_gmt ),
+            'dateUnix'     => $modified_gmt,
             'timeAgo'      => human_time_diff( $modified_gmt, $current ),
             'autosave'     => wp_is_post_autosave( $revision ),

trunk/wp-admin/js/revisions.js

@@ -15 +15 @@
         if ( revisions.debug )
             console.log.apply( console, arguments );
-    }
+    };
 
     // wp_localize_script transforms top-level numbers into strings. Undo that.
@@ -48 +48 @@
         model: revisions.model.Revision,
 
-        comparator: function( revision ) {
-            return revision.id;
+        comparator: function( a, b ) {
+            var a_ = a.get('dateUnix');
+            var b_ = b.get('dateUnix');
+            var cmp = (a_ > b_) - (a_ < b_);
+            if (cmp === 0 && a.id != b.id)
+                cmp = a.id < b.id ? -1 : 1;
+            return cmp;
         },