Changeset 24629

Timestamp:

07/10/2013 04:37:50 AM (10 years ago)

Author:

markjaquith

Message:

Revisions: Get rid of an unneccessary ID. IDs are a bad idea.

See #24425.

Location:

trunk/wp-admin

Files:

• css/wp-admin-rtl.css (modified) (1 diff)
• css/wp-admin.css (modified) (1 diff)
• js/revisions.js (modified) (2 diffs)
• revision.php (modified) (1 diff)

trunk/wp-admin/css/wp-admin-rtl.css

@@ -1005 +1005 @@
 }
 
-#restore-revision {
+.diff-header > input.restore-revision {
     margin-left: 0;
     margin-right: 10px;

trunk/wp-admin/css/wp-admin.css

@@ -3630 +3630 @@
 }
 
-#restore-revision {
+.diff-header > input.restore-revision {
     margin-left: 10px;
 }

trunk/wp-admin/js/revisions.js

@@ -463 +463 @@
 
         events: {
-            'click #restore-revision': 'restoreRevision'
+            'click .restore-revision': 'restoreRevision'
         },
 
@@ -477 +477 @@
         updateMeta: function( from, to ) {
             this.$el.html( this.template( this.model.toJSON() ) );
-
-            $('#restore-revision').prop( 'disabled', to.attributes.current );
+            this.$('.restore-revision').prop( 'disabled', to.attributes.current );
         }
     });

trunk/wp-admin/revision.php

@@ -177 +177 @@
             </div>
 
-            <input type="button" id="restore-revision" class="button button-primary" data-restore-link="{{{ data.restoreLink }}}" value="<?php esc_attr_e( 'Restore This Revision' )?>" />
+            <input type="button" class="restore-revision button button-primary" data-restore-link="{{{ data.restoreLink }}}" value="<?php esc_attr_e( 'Restore This Revision' )?>" />
         </div>
     </div>