Changeset 24646

Timestamp:

07/10/2013 07:17:01 PM (10 years ago)

Author:

markjaquith

Message:

Revisions: fixes for routing and initial setting of compareTwoMode

• Fix routing handler logic (compareTwoMode was reversed).
• Fix routing handler typo (both should use the same handler).
• Set compareTwoMode to false, to start. props duck_.

See #24425.

File:

• trunk/wp-admin/js/revisions.js (modified) (3 diffs)

trunk/wp-admin/js/revisions.js

@@ -249 +249 @@
             properties.to = this.revisions.get( revisions.settings.selectedRevision );
             properties.from = this.revisions.prev( properties.to );
+            properties.compareTwoMode = false;
             this.set( properties );
 
@@ -895 +896 @@
         routes: {
             'from/:from/to/:to': 'handleRoute',
-            'at/:to': 'routeSingle'
+            'at/:to': 'handleRoute'
         },
 
@@ -910 +911 @@
             var from, to, compareTwo;
 
-            // If `b` is undefined, this was a 'revision/:to' route
+            // If `b` is undefined, this is an 'at/:to' route, for a single revision
             if ( _.isUndefined( b ) ) {
                 b = a;
                 a = 0;
+                compareTwo = false;
+            } else {
                 compareTwo = true;
-            } else {
-                compareTwo = false;
             }