Changeset 24719

Timestamp:

07/17/2013 04:46:09 AM (12 years ago)

Author:

nacin

Message:

Avoid a sanitize_key() call on ID, as this causes it to be lowercased. wp_dropdown_users() requires user_login as a fallback; specify it for get_users(). see #21767.

File:

• trunk/wp-includes/user.php (modified) (2 diffs)

trunk/wp-includes/user.php

@@ -393 +393 @@
 
             $this->query_fields = array();
-            foreach ( $qv['fields'] as $field )
-                $this->query_fields[] = $wpdb->users . '.' . sanitize_key( $field );
+            foreach ( $qv['fields'] as $field ) {
+                $field = 'ID' === $field ? 'ID' : sanitize_key( $field );
+                $this->query_fields[] = "$wpdb->users.$field";
+            }
             $this->query_fields = implode( ',', $this->query_fields );
         } elseif ( 'all' == $qv['fields'] ) {
@@ -1030 +1032 @@
 
     $query_args = wp_array_slice_assoc( $r, array( 'blog_id', 'include', 'exclude', 'orderby', 'order', 'who' ) );
-    $query_args['fields'] = array( 'ID', $show );
+    $query_args['fields'] = array( 'ID', 'user_login', $show );
     $users = get_users( $query_args );