Changeset 24753

Timestamp:

07/19/2013 03:47:04 PM (13 years ago)

Author:

markjaquith

Message:

WORLD WAR Z-INDEX: Restoration of sanity to revisions/slider/menu z-index values.

The year is 2013. It is a period of DOM unrest. Sliders have hoarded
all available z-index, leading to an arms race. What started as a local
squabble soon escalated into a global conflict. The flyout menus were
the first of the collateral damage, trodden underfoot by mighty warring
enemies they couldn't effectively challenge. It was said they were
betrayed by one of their own: the z-index-power-hungry non-active
currently-hovered submenu, whose z-index-power level was over 9000!

But there is hope. A small band of heroes has emerged. Using their
powers of "what were you thinking?" and "chill, no one needs a z-index
THAT high", they have begun to restore order and harmony to the DOM.

See #24736. Props markjaquith, aaroncampbell, helen.

File:

• trunk/wp-admin/css/wp-admin.css (modified) (7 diffs)

trunk/wp-admin/css/wp-admin.css

@@ -1459 +1459 @@
 #adminmenu .wp-has-current-submenu.opensub .wp-submenu {
         position: relative;
-        z-index: 2;
+        z-index: 3;
         top: auto;
         left: auto;
@@ -3532 +3532 @@
         margin: 0 auto;
         height: 0.8em;
-        z-index: 2;
         top: 7px;
         width: 100%;
@@ -3545 +3544 @@
         height: 100%;
         float: left;
-        z-index: 3;
         border-style: solid;
         border-width: 0 1px 0 0;
@@ -3633 +3631 @@
 .revisions-next {
         position: relative;
-        z-index: 4;
+        z-index: 1;
 }
 
@@ -3744 +3742 @@
         margin-left: -70px;
         line-height: 28px;
-        z-index: 9999;
+        z-index: 1;
         max-width: 350px;
         min-width: 130px;
@@ -3858 +3856 @@
 .wp-slider .ui-slider-range {
         position: absolute;
-        z-index: 1;
         font-size: .7em;
         display: block;
@@ -3868 +3865 @@
 .wp-slider.ui-slider-horizontal {
         height: .8em;
-        z-index: 10001;
 }