Changeset 24790 for trunk/wp-admin/edit-form-advanced.php

Timestamp:

07/24/2013 06:08:14 AM (11 years ago)

Author:

nacin

Message:

Revisions changes.

• Eliminates the bloated Revisions meta box in favor of 'Revisions: #' in the publish box.
• Adds ability to compare autosave to current post, when revisions are disabled.
• Makes autosaves stand out visually, including "Restore This Autosave".

Also:

• Adds missing capability check for restoring a revision.
• When no revision matches the post's current modified time, avoid marking an autosave as 'current'.
• Fixes wp_get_post_autosave() to return an autosave even when revisions are disabled.
• Add 'check_enabled' arg to wp_get_post_revisions(); false avoids the wp_revisions_enabled() check.
• Adds a responsive slider that is narrower for fewer versions. props markjaquith.

see #24804.

File:

• trunk/wp-admin/edit-form-advanced.php (modified) (3 diffs)

trunk/wp-admin/edit-form-advanced.php

@@ -110 +110 @@
 require_once('./includes/meta-boxes.php');
 
+
+$publish_callback_args = null;
+if ( post_type_supports($post_type, 'revisions') && 'auto-draft' != $post->post_status ) {
+    $revisions = wp_get_post_revisions( $post_ID );
+
+    // Check if the revisions have been upgraded
+    if ( ! empty( $revisions ) && _wp_get_post_revision_version( end( $revisions ) ) < 1 )
+        _wp_upgrade_revisions_of_post( $post, $revisions );
+
+    // We should aim to show the revisions metabox only when there are revisions.
+    if ( count( $revisions ) > 1 ) {
+        reset( $revisions ); // Reset pointer for key()
+        $publish_callback_args = array( 'revisions_count' => count( $revisions ), 'revision_id' => key( $revisions ) );
+        // add_meta_box('revisionsdiv', __('Revisions'), 'post_revisions_meta_box', null, 'normal', 'core');
+    }
+}
+
 if ( 'attachment' == $post_type ) {
     wp_enqueue_script( 'image-edit' );
@@ -116 +133 @@
     add_action( 'edit_form_after_title', 'edit_form_image_editor' );
 } else {
-    add_meta_box( 'submitdiv', __( 'Publish' ), 'post_submit_meta_box', null, 'side', 'core' );
+    add_meta_box( 'submitdiv', __( 'Publish' ), 'post_submit_meta_box', null, 'side', 'core', $publish_callback_args );
 }
 
@@ -171 +188 @@
     if ( is_super_admin() || current_user_can( $post_type_object->cap->edit_others_posts ) )
         add_meta_box('authordiv', __('Author'), 'post_author_meta_box', null, 'normal', 'core');
-}
-
-if ( post_type_supports($post_type, 'revisions') && 'auto-draft' != $post->post_status ) {
-    $revisions = wp_get_post_revisions( $post_ID );
-
-    // Check if the revisions have been upgraded
-    if ( ! empty( $revisions ) && _wp_get_post_revision_version( end( $revisions ) ) < 1 )
-        _wp_upgrade_revisions_of_post( $post, $revisions );
-
-    // We should aim to show the revisions metabox only when there are revisions.
-    if ( count( $revisions ) > 1 )
-        add_meta_box('revisionsdiv', __('Revisions'), 'post_revisions_meta_box', null, 'normal', 'core');
 }