Changeset 24799

Timestamp:

07/27/2013 06:57:42 AM (10 years ago)

Author:

nacin

Message:

Don't show "Preview" for locked, non-public post types. props aaroncampbell. fixed #24139.

File:

• trunk/wp-admin/includes/post.php (modified) (3 diffs)

trunk/wp-admin/includes/post.php

@@ -1214 +1214 @@
     }
 
-    if ( $locked && ( $sendback = wp_get_referer() ) && 
+    if ( $locked && ( $sendback = wp_get_referer() ) &&
         false === strpos( $sendback, 'post.php' ) && false === strpos( $sendback, 'post-new.php' ) ) {
 
@@ -1236 +1236 @@
 
     if ( $locked ) {
-        $preview_link = set_url_scheme( add_query_arg( 'preview', 'true', get_permalink( $post->ID ) ) );
-
-        if ( 'publish' == $post->post_status || $user->ID != $post->post_author ) {
-            // Latest content is in autosave
-            $nonce = wp_create_nonce( 'post_preview_' . $post->ID );
-            $preview_link = add_query_arg( array( 'preview_id' => $post->ID, 'preview_nonce' => $nonce ), $preview_link );
+        if ( get_post_type_object( $post->post_type )->public ) {
+            $preview_link = set_url_scheme( add_query_arg( 'preview', 'true', get_permalink( $post->ID ) ) );
+
+            if ( 'publish' == $post->post_status || $user->ID != $post->post_author ) {
+                // Latest content is in autosave
+                $nonce = wp_create_nonce( 'post_preview_' . $post->ID );
+                $preview_link = add_query_arg( array( 'preview_id' => $post->ID, 'preview_nonce' => $nonce ), $preview_link );
+            }
+        } else {
+            $preview_link = '';
         }
 
@@ -1255 +1259 @@
         <p>
         <a class="button" href="<?php echo esc_url( $sendback ); ?>"><?php echo $sendback_text; ?></a>
+        <?php if ( $preview_link ) { ?>
         <a class="button<?php echo $tab_last; ?>" href="<?php echo esc_url( $preview_link ); ?>"><?php _e('Preview'); ?></a>
         <?php
+        }
 
         // Allow plugins to prevent some users overriding the post lock