Changeset 24976 for trunk/wp-includes/theme.php

Timestamp:

08/05/2013 09:40:28 PM (11 years ago)

Author:

nacin

Message:

Don't return false from search_theme_directories() when a single directory is not readable.

Issue a notice.

props csixty4.
fixes #24639.

File:

• trunk/wp-includes/theme.php (modified) (2 diffs)

trunk/wp-includes/theme.php

@@ -374 +374 @@
         // Start with directories in the root of the current theme directory.
         $dirs = @ scandir( $theme_root );
-        if ( ! $dirs )
-            return false;
+        if ( ! $dirs ) {
+            trigger_error( "$theme_root is not readable", E_USER_NOTICE );
+            continue;
+        }
         foreach ( $dirs as $dir ) {
             if ( ! is_dir( $theme_root . '/' . $dir ) || $dir[0] == '.' || $dir == 'CVS' )
@@ -391 +393 @@
                 // wp-content/themes is $theme_root, a-folder-of-themes is $dir, then themes are $sub_dirs
                 $sub_dirs = @ scandir( $theme_root . '/' . $dir );
-                if ( ! $sub_dirs )
-                    return false;
+                if ( ! $sub_dirs ) {
+                    trigger_error( "$theme_root/$dir is not readable", E_USER_NOTICE );
+                    continue;
+                }
                 foreach ( $sub_dirs as $sub_dir ) {
                     if ( ! is_dir( $theme_root . '/' . $dir . '/' . $sub_dir ) || $dir[0] == '.' || $dir == 'CVS' )