Changeset 25078

Timestamp:

08/21/2013 10:54:09 PM (13 years ago)

Author:

azaozz

Message:

Heartbeat: better queue functionality: improve enqueue() and isQueued(), introduce dequeue() and getQueuedItem(). Props evansolomon, fixes #25047.

File:

• trunk/src/wp-includes/js/heartbeat.js (modified) (2 diffs)

trunk/src/wp-includes/js/heartbeat.js

@@ -428 +428 @@
                 this.enqueue = function( handle, data, dont_overwrite ) {
                         if ( handle ) {
-                                if ( queue.hasOwnProperty( handle ) && dont_overwrite )
+                                if ( dont_overwrite && this.isQueued( handle ) )
                                         return false;
 
@@ -441 +441 @@
                  *
                  * $param string handle The handle for the data
-                 * $return mixed The data queued with that handle or null
+                 * $return bool Whether some data is queued with this handle
                  */
                 this.isQueued = function( handle ) {
-                        return queue[handle];
+                        if ( handle )
+                                return queue.hasOwnProperty( handle );
+                };
+
+                /**
+                 * Remove data with a particular handle from the queue
+                 *
+                 * $param string handle The handle for the data
+                 * $return void
+                 */
+                this.dequeue = function( handle ) {
+                        if ( handle )
+                                delete queue[handle];
+                };
+
+                /**
+                 * Get data that was enqueued with a particular handle
+                 *
+                 * $param string handle The handle for the data
+                 * $return mixed The data or undefined
+                 */
+                this.getQueuedItem = function( handle ) {
+                        if ( handle )
+                                return this.isQueued( handle ) ? queue[handle] : undefined;
                 };
         };