Changeset 25210

Timestamp:

09/02/2013 01:53:57 PM (11 years ago)

Author:

SergeyBiryukov

Message:

Avoid 'Only variables should be passed by reference' notice on plugin search. props daankortenbach. fixes #25217.

File:

• trunk/src/wp-admin/includes/plugin-install.php (modified) (1 diff)

trunk/src/wp-admin/includes/plugin-install.php

@@ -297 +297 @@
     }
 
-    $section = isset($_REQUEST['section']) ? wp_unslash( $_REQUEST['section'] ) : 'description'; //Default to the Description tab, Do not translate, API returns English.
-    if ( empty($section) || ! isset($api->sections[ $section ]) )
-        $section = array_shift( $section_titles = array_keys((array)$api->sections) );
+    $section = isset( $_REQUEST['section'] ) ? wp_unslash( $_REQUEST['section'] ) : 'description'; //Default to the Description tab, Do not translate, API returns English.
+    if ( empty( $section ) || ! isset( $api->sections[ $section ] ) ) {
+        $section_titles = array_keys( (array) $api->sections );
+        $section = array_shift( $section_titles );
+    }
 
     iframe_header( __('Plugin Install') );