Changeset 25241

Timestamp:

09/04/2013 07:40:17 PM (11 years ago)

Author:

wonderboymusic

Message:

Introduce description__like arg to get_terms(). Make description__like and name__like perform LIKEs with a wildcard on both sides of passed string. Previously, strings had to match the beginning of the name, so searching for burrito in This is a burrito would fail. Adds unit tests.

Props aaroncampbell for the original patch, 5 years ago.
Fixes #8214.

Location:

trunk

Files:

• src/wp-includes/taxonomy.php (modified) (3 diffs)
• tests/phpunit/tests/term/getTerms.php (modified) (1 diff)

trunk/src/wp-includes/taxonomy.php

@@ -1167 +1167 @@
  * case-insensitive. Default is an empty string.
  *
- * name__like - Returned terms' names will begin with the value of 'name__like',
+ * name__like - Returned terms' names will contain the value of 'name__like',
  * case-insensitive. Default is empty string.
+ *
+ * description__like - Returned terms' descriptions will contain the value of
+ *  'description__like', case-insensitive. Default is empty string.
  *
  * The argument 'pad_counts', if set to true will include the quantity of a term's
@@ -1223 +1226 @@
         'hide_empty' => true, 'exclude' => array(), 'exclude_tree' => array(), 'include' => array(),
         'number' => '', 'fields' => 'all', 'slug' => '', 'parent' => '',
-        'hierarchical' => true, 'child_of' => 0, 'get' => '', 'name__like' => '',
+        'hierarchical' => true, 'child_of' => 0, 'get' => '', 'name__like' => '', 'description__like' => '',
         'pad_counts' => false, 'offset' => '', 'search' => '', 'cache_domain' => 'core' );
     $args = wp_parse_args( $args, $defaults );
@@ -1346 +1349 @@
     if ( !empty($name__like) ) {
         $name__like = like_escape( $name__like );
-        $where .= $wpdb->prepare( " AND t.name LIKE %s", $name__like . '%' );
+        $where .= $wpdb->prepare( " AND t.name LIKE %s", '%' . $name__like . '%' );
+    }
+
+    if ( ! empty( $description__like ) ) {
+        $description__like = like_escape( $description__like );
+        $where .= $wpdb->prepare( " AND tt.description LIKE %s", '%' . $description__like . '%' );
     }
 

trunk/tests/phpunit/tests/term/getTerms.php

@@ -151 +151 @@
         $this->assertEqualSets( array( $term_id1, $term_id2 ), $terms );
     }
+
+    function test_get_terms_like() {
+        $term_id1 = $this->factory->tag->create( array( 'name' => 'burrito', 'description' => 'This is a burrito.' ) );
+        $term_id2 = $this->factory->tag->create( array( 'name' => 'taco', 'description' => 'Burning man.' ) );
+
+        $terms = get_terms( 'post_tag', array( 'hide_empty' => false, 'name__like' => 'bur', 'fields' => 'ids' ) );
+        $this->assertEqualSets( array( $term_id1 ), $terms );
+
+        $terms2 = get_terms( 'post_tag', array( 'hide_empty' => false, 'description__like' => 'bur', 'fields' => 'ids' ) );
+        $this->assertEqualSets( array( $term_id1, $term_id2 ), $terms2 );
+
+        $terms3 = get_terms( 'post_tag', array( 'hide_empty' => false, 'name__like' => 'Bur', 'fields' => 'ids' ) );
+        $this->assertEqualSets( array( $term_id1 ), $terms3 );
+
+        $terms4 = get_terms( 'post_tag', array( 'hide_empty' => false, 'description__like' => 'Bur', 'fields' => 'ids' ) );
+        $this->assertEqualSets( array( $term_id1, $term_id2 ), $terms4 );
+
+        $terms5 = get_terms( 'post_tag', array( 'hide_empty' => false, 'name__like' => 'ENCHILADA', 'fields' => 'ids' ) );
+        $this->assertEmpty( $terms5 );
+
+        $terms6 = get_terms( 'post_tag', array( 'hide_empty' => false, 'description__like' => 'ENCHILADA', 'fields' => 'ids' ) );
+        $this->assertEmpty( $terms6 );
+
+        $terms7 = get_terms( 'post_tag', array( 'hide_empty' => false, 'name__like' => 'o', 'fields' => 'ids' ) );
+        $this->assertEqualSets( array( $term_id1, $term_id2 ), $terms7 );
+
+        $terms8 = get_terms( 'post_tag', array( 'hide_empty' => false, 'description__like' => '.', 'fields' => 'ids' ) );
+        $this->assertEqualSets( array( $term_id1, $term_id2 ), $terms8 );
+    }
 }