Changeset 25244

Timestamp:

09/04/2013 08:55:05 PM (12 years ago)

Author:

wonderboymusic

Message:

Allow get_pages() to accept an array for the arg parent. Adds unit tests, some will fail until the next commit.

Fixes #9470.

Location:

trunk

Files:

• src/wp-includes/post.php (modified) (1 diff)
• tests/phpunit/tests/post.php (modified) (1 diff)

trunk/src/wp-includes/post.php

@@ -3736 +3736 @@
     }
 
-    if ( $parent >= 0 )
+    if ( is_array( $parent ) ) {
+        $post_parent__in = implode( ',', array_map( 'absint', (array) $parent ) );
+        if ( ! empty( $post_parent__in ) )
+            $where .= " AND post_parent IN ($post_parent__in)";
+    } elseif ( $parent >= 0 ) {
         $where .= $wpdb->prepare(' AND post_parent = %d ', $parent);
+    }
 
     if ( 1 == count( $post_status ) ) {

trunk/tests/phpunit/tests/post.php

@@ -824 +824 @@
         $this->assertEquals( $inc, $exc_result );
     }
+
+    function test_get_pages_parent() {
+        $page_id1 = $this->factory->post->create( array( 'post_type' => 'page' ) );
+        $page_id2 = $this->factory->post->create( array( 'post_type' => 'page', 'post_parent' => $page_id1 ) );
+        $page_id3 = $this->factory->post->create( array( 'post_type' => 'page', 'post_parent' => $page_id2 ) );
+        $page_id4 = $this->factory->post->create( array( 'post_type' => 'page', 'post_parent' => $page_id1 ) );
+
+        $pages = get_pages( array( 'parent' => 0, 'hierarchical' => false ) );
+        $this->assertEqualSets( array( $page_id1 ), wp_list_pluck( $pages, 'ID' ) );
+
+        $pages = get_pages( array( 'parent' => $page_id1, 'hierarchical' => false ) );
+        $this->assertEqualSets( array( $page_id2, $page_id4 ), wp_list_pluck( $pages, 'ID' ) );
+
+        $pages = get_pages( array( 'parent' => array( $page_id1, $page_id2 ), 'hierarchical' => false ) );
+        $this->assertEqualSets( array( $page_id2, $page_id3, $page_id4 ), wp_list_pluck( $pages, 'ID' ) );
+
+        $pages = get_pages( array( 'parent' => 0 ) );
+        $this->assertEqualSets( array( $page_id1 ), wp_list_pluck( $pages, 'ID' ) );
+
+        $pages = get_pages( array( 'parent' => $page_id1 ) );
+        $this->assertEqualSets( array( $page_id2, $page_id4 ), wp_list_pluck( $pages, 'ID' ) );
+
+        $pages = get_pages( array( 'parent' => array( $page_id1, $page_id2 ) ) );
+        $this->assertEqualSets( array( $page_id2, $page_id3, $page_id4 ), wp_list_pluck( $pages, 'ID' ) );
+    }
 }