Changeset 25255 for trunk/tests/phpunit/tests/meta.php

Timestamp:

09/05/2013 04:56:36 PM (13 years ago)

Author:

wonderboymusic

Message:

When meta_type is passed with orderby => meta_value, orderby must also use CAST() to avoid scenarios like: SELECTing by UNSIGNED and then ordering by CHAR. Adds unit test.

Fixes #21621.

File:

• trunk/tests/phpunit/tests/meta.php (modified) (1 diff)

trunk/tests/phpunit/tests/meta.php

@@ -151 +151 @@
                 $this->assertEquals( $expected2, get_metadata( 'user', $this->author->ID, $key, true ) );
         }
+
+        function test_meta_type_cast() {
+                $post_id1 = $this->factory->post->create();
+                add_post_meta( $post_id1, 'num_as_longtext', 123 );
+                $post_id2 = $this->factory->post->create();
+                add_post_meta( $post_id2, 'num_as_longtext', 99 );
+
+                $posts = new WP_Query( array(
+                        'fields' => 'ids',
+                        'post_type' => 'any',
+                        'meta_key' => 'num_as_longtext',
+                        'meta_value' => '0',
+                        'meta_compare' => '>',
+                        'meta_type' => 'UNSIGNED',
+                        'orderby' => 'meta_value',
+                        'order' => 'ASC'
+                ) );
+
+                $this->assertEquals( array( $post_id2, $post_id1 ), $posts->posts );
+                $this->assertEquals( 2, substr_count( $posts->request, 'CAST(' ) );
+        }
 }