Changeset 25277 for trunk/src/wp-admin/includes/media.php

Timestamp:

09/06/2013 02:09:07 PM (11 years ago)

Author:

SergeyBiryukov

Message:

Use correct array key for filling the attachment title in image_attachment_fields_to_save(). props pross.
Use wp_basename() to avoid issues with UTF-8 characters.
fixes #25236.

File:

• trunk/src/wp-admin/includes/media.php (modified) (2 diffs)

trunk/src/wp-admin/includes/media.php

@@ -915 +915 @@
  * @return array
  */
-function image_attachment_fields_to_save($post, $attachment) {
-    if ( substr($post['post_mime_type'], 0, 5) == 'image' ) {
-        if ( strlen(trim($post['post_title'])) == 0 ) {
-            $post['post_title'] = preg_replace('/\.\w+$/', '', basename($post['guid']));
-            $post['errors']['post_title']['errors'][] = __('Empty Title filled from filename.');
+function image_attachment_fields_to_save( $post, $attachment ) {
+    if ( substr( $post['post_mime_type'], 0, 5 ) == 'image' ) {
+        if ( strlen( trim( $post['post_title'] ) ) == 0 ) {
+            $attachment_url = ( isset( $post['attachment_url'] ) ) ? $post['attachment_url'] : $post['guid'];
+            $post['post_title'] = preg_replace( '/\.\w+$/', '', wp_basename( $attachment_url ) );
+            $post['errors']['post_title']['errors'][] = __( 'Empty Title filled from filename.' );
         }
     }
@@ -926 +927 @@
 }
 
-add_filter('attachment_fields_to_save', 'image_attachment_fields_to_save', 10, 2);
+add_filter( 'attachment_fields_to_save', 'image_attachment_fields_to_save', 10, 2 );
 
 /**