Changeset 25304

Timestamp:

09/09/2013 02:42:52 AM (13 years ago)

Author:

dd32

Message:

WP_Filesystem: Ensure that all files are read/written correctly by verifying the return values from fwrite() and using FTP_BINARY mode (ASCII converts line endings as per the spec). See #25237

Location:

trunk/src/wp-admin/includes

Files:

• class-wp-filesystem-direct.php (modified) (1 diff)
• class-wp-filesystem-ftpext.php (modified) (4 diffs)
• class-wp-filesystem-ftpsockets.php (modified) (2 diffs)
• class-wp-filesystem-ssh2.php (modified) (2 diffs)

trunk/src/wp-admin/includes/class-wp-filesystem-direct.php

@@ -60 +60 @@
          * @return bool False upon failure.
          */
-        function put_contents($file, $contents, $mode = false ) {
-                if ( ! ($fp = @fopen($file, 'w')) )
-                        return false;
-                @fwrite($fp, $contents);
-                @fclose($fp);
-                $this->chmod($file, $mode);
+        function put_contents( $file, $contents, $mode = false ) {
+                $fp = @fopen( $file, 'wb' );
+                if ( ! $fp )
+                        return false;
+
+                $bytes_written = fwrite( $fp, $contents );
+
+                fclose( $fp );
+
+                if ( false === $bytes_written || $bytes_written != strlen( $contents ) )
+                        return false;
+
+                $this->chmod( $file, $mode );
+
                 return true;
         }

trunk/src/wp-admin/includes/class-wp-filesystem-ftpext.php

@@ -89 +89 @@
         }
 
-        function get_contents($file, $type = '', $resumepos = 0 ) {
-                if ( empty($type) )
-                        $type = FTP_BINARY;
-
+        function get_contents( $file ) {
                 $tempfile = wp_tempnam($file);
                 $temp = fopen($tempfile, 'w+');
@@ -99 +96 @@
                         return false;
 
-                if ( ! @ftp_fget($this->link, $temp, $file, $type, $resumepos) )
+                if ( ! @ftp_fget($this->link, $temp, $file, FTP_BINARY ) )
                         return false;
 
@@ -118 +115 @@
         function put_contents($file, $contents, $mode = false ) {
                 $tempfile = wp_tempnam($file);
-                $temp = fopen($tempfile, 'w+');
+                $temp = fopen( $tempfile, 'wb+' );
                 if ( ! $temp )
                         return false;
 
-                fwrite($temp, $contents);
-                fseek($temp, 0); //Skip back to the start of the file being written to
-
-                $type = $this->is_binary($contents) ? FTP_BINARY : FTP_ASCII;
-                $ret = @ftp_fput($this->link, $file, $temp, $type);
+                $bytes_written = fwrite( $temp, $contents );
+                if ( false === $bytes_written || $bytes_written != strlen( $contents ) ) {
+                        fclose( $temp );
+                        unlink( $tempfile );
+                        return false;
+                }
+
+                fseek( $temp, 0 ); // Skip back to the start of the file being written to
+
+                $ret = @ftp_fput( $this->link, $file, $temp, FTP_BINARY );
 
                 fclose($temp);
@@ -188 +190 @@
                         return false;
                 $content = $this->get_contents($source);
-                if ( false === $content)
+                if ( false === $content )
                         return false;
                 return $this->put_contents($destination, $content, $mode);

trunk/src/wp-admin/includes/class-wp-filesystem-ftpsockets.php

@@ -76 +76 @@
                 }
 
-                $this->ftp->SetType(FTP_AUTOASCII);
-                $this->ftp->Passive(true);
-                $this->ftp->setTimeout(FS_TIMEOUT);
+                $this->ftp->SetType( FTP_BINARY );
+                $this->ftp->Passive( true );
+                $this->ftp->setTimeout( FS_TIMEOUT );
                 return true;
         }
 
-        function get_contents($file, $type = '', $resumepos = 0) {
+        function get_contents( $file ) {
                 if ( ! $this->exists($file) )
                         return false;
-
-                if ( empty($type) )
-                        $type = FTP_AUTOASCII;
-                $this->ftp->SetType($type);
 
                 $temp = wp_tempnam( $file );
@@ -123 +119 @@
                 }
 
-                fwrite($temphandle, $contents);
-                fseek($temphandle, 0); //Skip back to the start of the file being written to
-
-                $type = $this->is_binary($contents) ? FTP_BINARY : FTP_ASCII;
-                $this->ftp->SetType($type);
+                $bytes_written = fwrite( $temphandle, $contents );
+                if ( false === $bytes_written || $bytes_written != strlen( $contents ) ) {
+                        fclose( $temphandle );
+                        unlink( $temp );
+                        return false;
+                }
+
+                fseek( $temphandle, 0 ); // Skip back to the start of the file being written to
 
                 $ret = $this->ftp->fput($file, $temphandle);

trunk/src/wp-admin/includes/class-wp-filesystem-ssh2.php

@@ -151 +151 @@
         }
 
-        function get_contents($file, $type = '', $resumepos = 0 ) {
+        function get_contents( $file ) {
                 $file = ltrim($file, '/');
                 return file_get_contents('ssh2.sftp://' . $this->sftp_link . '/' . $file);
@@ -165 +165 @@
                 $ret = file_put_contents('ssh2.sftp://' . $this->sftp_link . '/' . $file, $contents);
 
+                if ( $ret !== strlen( $contents ) )
+                        return false;
+
                 $this->chmod($file, $mode);
 
-                return false !== $ret;
+                return true;
         }