Changeset 25331

Timestamp:

09/10/2013 11:09:10 PM (13 years ago)

Author:

wonderboymusic

Message:

Support orderby => meta_value in WP_User_Query. Adds unit test.

Props wpsmith.
Fixes #21581.

Location:

trunk

Files:

• src/wp-includes/user.php (modified) (1 diff)
• tests/phpunit/tests/user/query.php (modified) (1 diff)

trunk/src/wp-includes/user.php

@@ -436 +436 @@
                 } elseif ( 'ID' == $qv['orderby'] || 'id' == $qv['orderby'] ) {
                         $orderby = 'ID';
+                } elseif ( 'meta_value' == $qv['orderby'] ) {
+                        $orderby = "$wpdb->usermeta.meta_value";
                 } else {
                         $orderby = 'user_login';

trunk/tests/phpunit/tests/user/query.php

@@ -77 +77 @@
                 }
         }
+
+        function test_orderby() {
+                $user_ids = $this->factory->user->create_many( 10, array(
+                        'role' => 'author'
+                ) );
+
+                $names = array( 'd', 'f', 'n', 'f', 'd', 'j', 'r', 'p', 'h', 'g' );
+
+                foreach ( $names as $i => $name )
+                        update_user_meta( $user_ids[$i], 'last_name', $name );
+
+                $u = new WP_User_Query( array(
+                        'include' => $user_ids,
+                        'meta_key' => 'last_name',
+                        'orderby' => 'meta_value',
+                        'fields' => 'ids'
+                ) );
+                $values = array();
+                foreach ( $u->get_results() as $user )
+                        $values[] = get_user_meta( $user, 'last_name', true );
+
+                sort( $names );
+
+                $this->assertEquals( $names, $values );
+        }
 }